Remove ConcurrencyFactor from IHostEnvironment#2846
Conversation
|
Note that the first and second commit contain the most important logical changes the rest are fixes to tests and samples to make sure they compile. |
Codecov Report
@@ Coverage Diff @@
## master #2846 +/- ##
==========================================
- Coverage 71.69% 71.69% -0.01%
==========================================
Files 811 811
Lines 142546 142494 -52
Branches 16125 16112 -13
==========================================
- Hits 102193 102155 -38
+ Misses 35924 35918 -6
+ Partials 4429 4421 -8
|
Actually that's interesting. We need to hide this for now, just as a we had to hide Edit: To address this problem I've introduced issue #2848 and PR #2849. It had somehow escaped my notice that we had a random model just lying around claiming to be a value mapper. (And thereby introducing the bug you observed.) That's obviously not going to fly... #Resolved |
Please validate what output in samples are same across all files in this PR In reply to: 469970156 [](ancestors = 469970156) Refers to: docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/Clustering/KMeans.cs:45 in a8c7541. [](commit_id = a8c7541, deletion_comment = False) |
| @@ -59,14 +59,7 @@ public interface IHostEnvironment : IChannelProvider, IProgressChannelProvider | |||
| /// <summary> | |||
| /// Create a host with the given registration name. | |||
| /// </summary> | |||
There was a problem hiding this comment.
Please explain what seed and verbose are.
Fixes #2051.
In this PR I remove
ConcurrencyFactorfromIHostEnvironmentand interfaces and classes deriving/implementing it.I had to skip a
RandomPredictoras I am not sure how I can require a single threaded behavior without theConcurrencyFactorfor this specific trainer.