Renaming CI legs

[Anipik]

The previous pr was alwayus using the mac machines with missing dependencies so just creating a new pr to avoid those failures.

@eerhardt is it fine to run centos just with netcoreapp3.0 and ubuntu with netcoreapp2.1 ?

[Anipik]

@artidoro the mac ci legs are still failing

[codecov]

Codecov Report

Merging #3553 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3553      +/-   ##
==========================================
- Coverage   72.77%   72.76%   -0.01%     
==========================================
  Files         808      808              
  Lines      145452   145452              
  Branches    16244    16244              
==========================================
- Hits       105846   105839       -7     
- Misses      35185    35192       +7     
  Partials     4421     4421

Flag	Coverage Δ
#Debug	72.76% <ø> (-0.01%)	⬇️
#production	68.27% <ø> (-0.01%)	⬇️
#test	89.04% <ø> (-0.01%)	⬇️

Impacted Files	Coverage Δ
src/Microsoft.ML.Transforms/Text/LdaTransform.cs	89.26% <0%> (-0.63%)	⬇️
...soft.ML.TestFramework/DataPipe/TestDataPipeBase.cs	73.73% <0%> (-0.33%)	⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs	84.7% <0%> (-0.21%)	⬇️
src/Microsoft.ML.TimeSeries/IidSpikeDetector.cs	72.54% <0%> (ø)	⬆️
src/Microsoft.ML.Transforms/CategoricalCatalog.cs	68.42% <0%> (ø)	⬆️
src/Microsoft.ML.Data/Transforms/Hashing.cs	92.32% <0%> (ø)	⬆️
...dardTrainers/Standard/Online/AveragedPerceptron.cs	89.7% <0%> (ø)	⬆️
...rosoft.ML.Transforms/FourierDistributionSampler.cs	84.16% <0%> (ø)	⬆️
src/Microsoft.ML.PCA/PcaTrainer.cs	79.94% <0%> (ø)	⬆️
...LogisticRegression/MulticlassLogisticRegression.cs	67.61% <0%> (ø)	⬆️
... and 51 more

[artidoro]

Looks a lot better already!

I have the following comments:

• Could you Pascal case the names? Netcoreapp -> NetCoreApp
• Could you remove the app from the name? NetCoreApp -> NetCore
• Could you do the same for netfx? netfx -> NetFx
• Could you specify which version of NetFx we are using? (if you think it's useful)

[artidoro]

On a separate note, is it possible to add a period in the name?
For example NetCore_3.0 or NetCore3.0 instead of NetCore30.

[Anipik]

Could you remove the app from the name? NetCoreApp -> NetCore

Actually eric told me to keep that as we dont use netcore anywhere

Could you do the same for netfx? netfx -> NetFx

Its actually azure thats changing it automatiically from uppercase to lowercase

Could you specify which version of NetFx we are using? (if you think it's useful)

Its not that useful but I can add that, as it may fix our lowercase problem

[artidoro]

It is strange that it is not keeping the Pascal case on NetCoreApp!
Do you have any ideas on how to fix that?

[Anipik]

It is strange that it is not keeping the Pascal case on NetCoreApp!

It does weird things :P

[danmoseley]

explicit architecture: x64 ?

[Anipik]

Actually the default value of this architecture variable is x64 which we set here https://github.com/dotnet/machinelearning/pull/3553/files/251954988b8ebd8e2dd8c1eb420a5e7c09095dac#diff-51ce39ab4212d73da272ba04e66b0b3bR3

[danmoseley]

Seems OK to me. Next time if you can avoid reordering, the diff is easier to read.

[Anipik]

Next time if you can avoid reordering, the diff is easier to read.

Actually ML team wanted these reorderings. but yeah i will split the reordering into a separate commit from next time

[eerhardt]

Why do we need “Build” in all the names?

[Anipik]

Why do we need “Build” in all the names?

chocsta mentioned in the previous PR and naming the job matrices as debug and release can cause some problems with azure dev ops #3314 (comment)

[eerhardt]

@eerhardt is it fine to run centos just with netcoreapp3.0 and ubuntu with netcoreapp2.1 ?

It was nice getting a mix of the two that we were doing previously, but I think we should be OK.

[shauheen]

@Anipik this seems to have broken the build badges on the main readme.

[Anipik]

@shauheen We need to update the job names there as well. i Will put up the PR for it.

[Anipik]

We need to update the links

[Anipik]

i found the new links to apis