Skip to content

Implement ToString() method for DataFrameColumn class#7103

Merged
michaelgsharp merged 5 commits intodotnet:mainfrom
asmirnov82:7101_dataframecolumn_tostring
Apr 3, 2024
Merged

Implement ToString() method for DataFrameColumn class#7103
michaelgsharp merged 5 commits intodotnet:mainfrom
asmirnov82:7101_dataframecolumn_tostring

Conversation

@asmirnov82
Copy link
Copy Markdown
Contributor

Fixes #7101

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 68.48%. Comparing base (214e12a) to head (e264f14).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7103      +/-   ##
==========================================
- Coverage   68.49%   68.48%   -0.01%     
==========================================
  Files        1262     1262              
  Lines      254295   254320      +25     
  Branches    26242    26246       +4     
==========================================
- Hits       174182   174179       -3     
- Misses      73424    73450      +26     
- Partials     6689     6691       +2     
Flag Coverage Δ
Debug 68.48% <0.00%> (-0.01%) ⬇️
production 62.88% <0.00%> (-0.01%) ⬇️
test 88.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...sis/DataFrameColumns/ArrowStringDataFrameColumn.cs 63.54% <0.00%> (ø)
...Analysis/DataFrameColumns/StringDataFrameColumn.cs 71.42% <0.00%> (ø)
...nalysis/DataFrameColumns/VBufferDataFrameColumn.cs 45.77% <0.00%> (ø)
...icrosoft.Data.Analysis/PrimitiveDataFrameColumn.cs 72.53% <0.00%> (+0.23%) ⬆️
src/Microsoft.Data.Analysis/Strings.Designer.cs 41.49% <0.00%> (-0.87%) ⬇️
src/Microsoft.Data.Analysis/DataFrame.cs 85.42% <0.00%> (-1.31%) ⬇️
src/Microsoft.Data.Analysis/DataFrameColumn.cs 62.83% <0.00%> (-4.32%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Copy Markdown
Contributor

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@michaelgsharp michaelgsharp merged commit 99d5c1d into dotnet:main Apr 3, 2024
@asmirnov82 asmirnov82 deleted the 7101_dataframecolumn_tostring branch April 3, 2024 19:53
@github-actions github-actions Bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Override ToString() method of DataFrame column to provide list of values

2 participants