Skip to content

update torchsharp and helix image#7188

Merged
LittleLittleCloud merged 5 commits intodotnet:mainfrom
LittleLittleCloud:u/fix#7182
Jul 17, 2024
Merged

update torchsharp and helix image#7188
LittleLittleCloud merged 5 commits intodotnet:mainfrom
LittleLittleCloud:u/fix#7182

Conversation

@LittleLittleCloud
Copy link
Copy Markdown
Member

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

fix #7182

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.80%. Comparing base (77e9024) to head (9bad7a2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7188      +/-   ##
==========================================
- Coverage   68.94%   68.80%   -0.15%     
==========================================
  Files        1397     1267     -130     
  Lines      266970   259501    -7469     
  Branches    27600    26910     -690     
==========================================
- Hits       184062   178545    -5517     
+ Misses      75802    74084    -1718     
+ Partials     7106     6872     -234     
Flag Coverage Δ
Debug 68.80% <33.33%> (-0.15%) ⬇️
production 63.07% <33.33%> (-0.46%) ⬇️
test 88.96% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Microsoft.ML.TorchSharp/AutoFormerV2/ConvModule.cs 100.00% <100.00%> (ø)
....ML.TorchSharp/NasBert/Optimizers/BaseOptimizer.cs 50.00% <0.00%> (ø)

... and 169 files with indirect coverage changes

Comment thread src/Microsoft.ML.GenAI.Core/Microsoft.ML.GenAI.Core.csproj
Copy link
Copy Markdown
Contributor

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LittleLittleCloud
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@LittleLittleCloud
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@LittleLittleCloud
Copy link
Copy Markdown
Member Author

/azd run

@LittleLittleCloud
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@LittleLittleCloud LittleLittleCloud merged commit 05bb0e3 into dotnet:main Jul 17, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helix test fail on latest torchsharp (0.102.5) and its runtime

2 participants