-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Use arcade script for installing MacOS dependencies #7533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR optimizes macOS build times by replacing manual dependency installation with the arcade script used across dotnet repositories. The change eliminates a 30+ minute overhead caused by building dependencies like CMake and OpenSSL from source.
Key Changes:
- Replaced
brew updatewith arcade'sinstall-dependencies.shscript for macOS builds - Applied change consistently across all macOS build configurations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build/vsts-ci.yml | Updated two macOS build job configurations to use arcade script |
| build/ci/job-template.yml | Updated macOS-specific dependency installation step to use arcade script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7533 +/- ##
==========================================
- Coverage 69.02% 69.02% -0.01%
==========================================
Files 1482 1482
Lines 274092 274093 +1
Branches 28266 28266
==========================================
- Hits 189193 189191 -2
- Misses 77511 77520 +9
+ Partials 7388 7382 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Windows ARM helix queues are busted. Bypassing. |
|
/backport to release/4.0 |
|
Started backporting to |
Building on MacOS was taking an additional 30+ minutes as it built dependencies like CMake, OpenSSL, etc from source.
Leverage the common script for installing dependencies used by runtime and other dotnet repos.