-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update mac build machines #7558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the macOS build infrastructure from macOS-13 to macOS-15 in response to the deprecation of macOS-13 build agents. The key changes ensure builds run on supported infrastructure while maintaining backward compatibility with macOS 13 as a deployment target.
- Updates all Azure DevOps pipeline configurations to use macOS-15 build agents
- Adds explicit
CMAKE_OSX_DEPLOYMENT_TARGETsetting to maintain macOS 13 as the minimum deployment target - Updates CMake comment to clarify bidirectional cross-compilation capability
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Native/CMakeLists.txt | Adds explicit macOS 13 deployment target and updates comment to clarify bidirectional cross-compilation |
| build/vsts-ci.yml | Updates MacImage variable from macOS-13 to macOS-15 |
| build/.night-build.yml | Updates nightly build vmImage from macOS-13 to macOS-15 |
| .vsts-dotnet-ci.yml | Updates vmImage to macOS-15 for both AMD64 and ARM64 job configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7558 +/- ##
==========================================
- Coverage 69.02% 69.02% -0.01%
==========================================
Files 1482 1482
Lines 274096 274096
Branches 28266 28266
==========================================
- Hits 189193 189191 -2
+ Misses 77521 77518 -3
- Partials 7382 7387 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tarekgh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
|
/backport to release/5.0 |
|
Started backporting to |
MacOS build agents are no longer supported -- actions/runner-images#13046
This updates to use the latest, while still not "floating" so that we have deterministic behavior.
I added
CMAKE_OSX_DEPLOYMENT_TARGETto ensure we still target macOS 13 (implicit before).I kept the Helix queues at 13 to ensure we still run there.