Updates to Unit Test cases for the TensorFlowTransform #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2018
Contributor
Can you please fix this too? this was my typo. Eric E. had comment on this. One of them is Refers to: test/Microsoft.ML.Tests/ScenariosWithDirectInstantiation/TensorflowTests.cs:122 in 88db7be. [](commit_id = 88db7be, deletion_comment = False) |
eerhardt
reviewed
Aug 31, 2018
| var thrown = false; | ||
| try | ||
| { | ||
| IDataView trans = TensorFlowTransform.Create(env, pixels, model_location, "Output", "Input"); |
Member
There was a problem hiding this comment.
Can use Assert.Throws instead of manually try catching. #Pending
Member
Author
There was a problem hiding this comment.
for now i am keeping this as-is. will consider using Assert.Throws in future
In reply to: 214481486 [](ancestors = 214481486)
Member
|
Thanks for fixing these up. #Resolved |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #779
(1) address the additional comments on the original TensorFlowTransform PR
(2) added an additional unit test to verify invalid shapes are being handled correctly