Updates to Unit Test cases for the TensorFlowTransform #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to latest dotnet/master
Latest dotnet/master
merge with latest master
Merge with latest dotnet/master
Merge with latest dotnet master
Converted the following transforms to Estimators: - ImageLoader - ImageResizer - ImagePixelExtractor - ImageGrayscale Fixes #707
* simplify and cleanup the code, remove dead code * use `Target` to specify that given setup method should be executed for selected benchmarks, not all * consume the result of Predict to make sure it does not get dead-code eliminated * reference input files from .csproj and copy them to output dir, don't rely on hardcoded folder hierarchy * every ML.NET benchmark allocates a lot of memory and should be executed in a dedicated process * make it possible for every type to report different metrics * enforce current culture as "en-us" because the input data files use dot as decimal separator (and it fails for cultures with ",") * for our time consuming benchmarks 1 warmup iteration is enough * workaround for the auto-generated code to avoid name coflict for Microsoft.ML.Runtime.IHost and BenchmarkDotNet.Engines.IHost.. * add comment about why we need a custom toolchain * update BDN version to allow benchmarking with CoreRun * code review fix: spacing
* Attribution of images in test/data/images * Attribution of images in test/data/images * Just to trigger the build
…ve (#788) * Stored all native benchmarks in a new class and cleaned up function names * Style change: turn braces into one-liners * Changed ShortRun to Default: run the perf tests longer to give more accurate results * Added back necessary usings
Member
Author
|
Looks like the commit history has pulled in unrelated commits. Created a new PR #790 for this |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #779
(1) address the additional comments on the original TensorFlowTransform PR
(2) added an additional unit test to verify invalid shapes are being handled correctly