[net9.0] [dotnet] Fix building universal apps using NativeAOT when the default RuntimeIdentifiers value is set. Fixes #19391.#21420
Conversation
… RuntimeIdentifiers value is set. Fixes #19391. We need to set "UseCurrentRuntimeIdentifier=false", we must only set it for the outer build for universal builds - when `RuntimeIdentifiers` is set - but that means we can only do it *after* we set any default value for `RuntimeIdentifiers`. Fixes #19391 (comment).
📚 [CI Build] Artifacts 📚Artifacts were not provided. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)
✅ API diff vs stable.NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 99 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
We need to set "UseCurrentRuntimeIdentifier=false", we must only set it for
the outer build for universal builds - when
RuntimeIdentifiersis set - butthat means we can only do it after we set any default value for
RuntimeIdentifiers.Fixes #19391 (comment).
Backport of #21412