[nuget-msi-convert] Support improved VS component IDs by pjcollins · Pull Request #21423 · dotnet/macios

pjcollins · 2024-10-11T16:37:29Z

Context: dotnet/arcade@b2d3a3a
Context: https://github.com/xamarin/yaml-templates/pull/339

The VS insertion manifest generation has been updated to use new VS
component IDs required for .NET 9+.

Context: dotnet/arcade@b2d3a3a Context: xamarin/yaml-templates#339 The VS insertion manifest generation has been updated to use new VS component IDs required for .NET 9+.

dalexsoto · 2024-10-11T17:19:31Z

@pjcollins once done please also backport this to our main branch so it is not lost

pjcollins · 2024-10-11T17:48:50Z

@pjcollins once done please also backport this to our main branch so it is not lost

This is one of those changes that should only be applied for .NET 9 and later. When will main be updated to produce .NET 9 builds by default? I assume at some point this branch will be merged back into main?

dalexsoto · 2024-10-11T18:05:04Z

@pjcollins our main branch is already net9 as of RC2, that said net9.0 is the branch we will use to produce rtm

pjcollins · 2024-10-11T18:46:11Z

@pjcollins our main branch is already net9 as of RC2, that said net9.0 is the branch we will use to produce rtm

Thanks good to know, will make sure this gets back into main as well

vs-mobiletools-engineering-service2 · 2024-10-14T20:17:23Z

📚 [CI Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-10-14T20:30:20Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 1ae0299c8283242cc692590e104d0b21fa1634cb [PR build]

vs-mobiletools-engineering-service2 · 2024-10-14T20:35:01Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 1ae0299c8283242cc692590e104d0b21fa1634cb [PR build]

vs-mobiletools-engineering-service2 · 2024-10-14T20:40:39Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 1ae0299c8283242cc692590e104d0b21fa1634cb [PR build]

vs-mobiletools-engineering-service2 · 2024-10-14T20:44:58Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 1ae0299c8283242cc692590e104d0b21fa1634cb [PR build]

vs-mobiletools-engineering-service2 · 2024-10-14T20:45:39Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 1ae0299c8283242cc692590e104d0b21fa1634cb [PR build]

vs-mobiletools-engineering-service2 · 2024-10-14T20:51:53Z

✅ API diff for current PR / commit

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 1ae0299c8283242cc692590e104d0b21fa1634cb [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T02:49:42Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 99 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ generator: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker: All 40 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download

Pipeline on Agent
Hash: 1ae0299c8283242cc692590e104d0b21fa1634cb [PR build]

rolfbjarne · 2024-10-15T07:15:59Z

/sudo backport main

vs-mobiletools-engineering-service2 · 2024-10-15T07:17:44Z

Backport Job to branch main Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2024-10-15T07:21:16Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10389961 for more details.

Context: dotnet/arcade@b2d3a3a Context: xamarin/yaml-templates#339 The VS insertion manifest generation has been updated to use new VS component IDs required for .NET 9+. Backport of #21423 --------- Co-authored-by: Peter Collins <pecolli@microsoft.com>

Context: dotnet/arcade@b2d3a3a Context: https://github.com/xamarin/yaml-templates/pull/339 The VS insertion manifest generation has been updated to use new VS component IDs required for .NET 9+. Backport of #21423 --------- Co-authored-by: Peter Collins <pecolli@microsoft.com>

Context: dotnet/arcade@b2d3a3a Context: xamarin/yaml-templates#339 The VS insertion manifest generation has been updated to use new VS component IDs required for .NET 10+. Re-application of #21423 for .NET 10+. See also #21476. --------- Co-authored-by: Peter Collins <pecolli@microsoft.com>

[nuget-msi-convert] Support improved VS component IDs

eff078b

Context: dotnet/arcade@b2d3a3a Context: xamarin/yaml-templates#339 The VS insertion manifest generation has been updated to use new VS component IDs required for .NET 9+.

pjcollins requested a review from mandel-macaque October 11, 2024 16:37

dalexsoto requested a review from rolfbjarne October 11, 2024 17:19

This comment has been minimized.

Sign in to view

Bump build

ab9037e

This comment has been minimized.

Sign in to view

Use yaml-templates main

1ae0299

pjcollins marked this pull request as ready for review October 14, 2024 18:43

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Oct 15, 2024

View reviewed changes

rolfbjarne merged commit 2f3ae24 into net9.0 Oct 15, 2024

rolfbjarne deleted the release-test/msi-vswl-newid branch October 15, 2024 07:15

vs-mobiletools-engineering-service2 mentioned this pull request Oct 15, 2024

[main] [nuget-msi-convert] Support improved VS component IDs #21438

Merged

Conversation

pjcollins commented Oct 11, 2024

Uh oh!

dalexsoto commented Oct 11, 2024

Uh oh!

pjcollins commented Oct 11, 2024

Uh oh!

dalexsoto commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

pjcollins commented Oct 11, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 14, 2024

📚 [CI Build] Artifacts 📚

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 14, 2024

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 14, 2024

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 14, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 14, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 14, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 14, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 15, 2024

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

rolfbjarne commented Oct 15, 2024

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 15, 2024

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dalexsoto commented Oct 11, 2024 •

edited

Loading