-
Notifications
You must be signed in to change notification settings - Fork 554
[devops] Include the macOS tests in the main test pipeline. #22420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
9f25e9f to
8e25ca4
Compare
* Include the macOS tests (build & test) in the main test pipeline. * Remove the now unused macos-tests pipelines. The downside is that we'll get the results for the macOS tests a bit later, because we won't start building the macOS tests until the main build is complete (as opposed to previously, when we'd build the macOS tests in parallel with the main build). This shouldn't slow down PR testing though, because the macOS tests isn't the slowest part (by far). This simplifies the existing pipelines, and also makes it possible to eventually create a single GitHub comment that reports the results from all tests (this will come in a later PR).
8e25ca4 to
d0c22bc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #28141f1] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #28141f1] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [PR Build #28141f1] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commit.NET ( No breaking changes )❗ API diff vs stable (Breaking changes).NET ( ❗ Breaking changes ❗ )✅ Generator diffGenerator diff is empty Pipeline on Agent |
✅ [CI Build #28141f1] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #28141f1] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #28141f1] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #28141f1] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #28141f1] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
🚀 [CI Build #28141f1] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 115 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
We have discussed this PR during our standup and agreed to take it, this should simplify our pipelines and future test results. |
The downside is that we'll get the results for the macOS tests a bit later, because
we won't start building the macOS tests until the main build is complete (as opposed
to previously, when we'd build the macOS tests in parallel with the main build).
This shouldn't slow down PR testing though, because the macOS tests isn't the slowest
part (by far).
This simplifies the existing pipelines, and also makes it possible to eventually
create a single GitHub comment that reports the results from all tests (this will
come in a later PR).