Skip to content

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Mar 18, 2025

  • Include the macOS tests (build & test) in the main test pipeline.
  • Remove the now unused macos-tests pipelines.

The downside is that we'll get the results for the macOS tests a bit later, because
we won't start building the macOS tests until the main build is complete (as opposed
to previously, when we'd build the macOS tests in parallel with the main build).
This shouldn't slow down PR testing though, because the macOS tests isn't the slowest
part (by far).

This simplifies the existing pipelines, and also makes it possible to eventually
create a single GitHub comment that reports the results from all tests (this will
come in a later PR).

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne force-pushed the dev/rolf/devops-unify-tests branch from 9f25e9f to 8e25ca4 Compare March 31, 2025 13:38
* Include the macOS tests (build & test) in the main test pipeline.
* Remove the now unused macos-tests pipelines.

The downside is that we'll get the results for the macOS tests a bit later, because
we won't start building the macOS tests until the main build is complete (as opposed
to previously, when we'd build the macOS tests in parallel with the main build).
This shouldn't slow down PR testing though, because the macOS tests isn't the slowest
part (by far).

This simplifies the existing pipelines, and also makes it possible to eventually
create a single GitHub comment that reports the results from all tests (this will
come in a later PR).
@rolfbjarne rolfbjarne force-pushed the dev/rolf/devops-unify-tests branch from 8e25ca4 to d0c22bc Compare March 31, 2025 13:38
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #28141f1] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 28141f1462af64713cf736866991f8a1cee86ca0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #28141f1] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 28141f1462af64713cf736866991f8a1cee86ca0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #28141f1] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 28141f1462af64713cf736866991f8a1cee86ca0 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 28141f1462af64713cf736866991f8a1cee86ca0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #28141f1] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 28141f1462af64713cf736866991f8a1cee86ca0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #28141f1] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 28141f1462af64713cf736866991f8a1cee86ca0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #28141f1] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 28141f1462af64713cf736866991f8a1cee86ca0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #28141f1] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 28141f1462af64713cf736866991f8a1cee86ca0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #28141f1] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 28141f1462af64713cf736866991f8a1cee86ca0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #28141f1] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 28141f1462af64713cf736866991f8a1cee86ca0 [PR build]

@rolfbjarne rolfbjarne marked this pull request as ready for review April 1, 2025 06:19
@dalexsoto
Copy link
Member

We have discussed this PR during our standup and agreed to take it, this should simplify our pipelines and future test results.

@rolfbjarne rolfbjarne merged commit 9dcdefa into main Apr 7, 2025
44 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/devops-unify-tests branch April 7, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants