[net10.0] Merge main into net10.0.#22432
Merged
rolfbjarne merged 54 commits intonet10.0from Mar 24, 2025
Merged
Conversation
…y. (#22342) Array types a special because we have to track the array element type rathern that the actual SpecialType of the array (which is SpecialType.None). We add a new property to our data model to track the special type of the element and we create a helper tuple to keep the switch expression clean. This could have been done without the helper tuple, but the code look a lot worse, the compiler is smart enough to remove that extra tuple. --------- Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
…#22327) Now that we have the binding struct we can update the workers to get it and use its data to perform the needed transformation. --------- Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
This has to be done in parts, because the Roslyn importer runs out of memory otherwise. Which also means I have no idea how many parts there will end up being. Partial fix for #17399.
We don't support 32-bit iOS architectures anymore, so these test cases do nothing.
Because we now have a GetValue method that takes a NativeHandle, we can
simplify the code generated when we are dealing with a smart enum in a
BindAs decorated property/method.
The old generated code is:
```csharp
ret = global::CoreAnimation.CACornerCurveExtensions.GetValue (Runtime.GetNSObject<NSString> (global::ObjCRuntime.Messaging.NativeHandle_objc_msgSend (this.Handle, Selector.GetHandle ("cornerCurve")), false)!);
```
While the new one is:
```csharp
ret = global::NaturalLanguage.NLLanguageExtensions.GetValue (global::ObjCRuntime.Messaging.NativeHandle_objc_msgSendSuper (this.SuperHandle, Selector.GetHandle ("language")));
```
The code is simpler, but there is also a small memory imrpovement. In
the old version of the binding, we were not callin the Dispose method in
the NSString. On the other hand, the new code uses the GetValue method
that is disposing the NSString as soon as it leaves the method and
therefore it does not need the GC to take care of it.
PS: There is no need to change the code that creates the wrapper because
we are using method overloading.
---------
Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
We will want to be able to generate code that references to the generated classes. Rather than having a pattern placed all over the project, we create a static class that given a string it will return the name to be used by the emitters. This, for example, will later be useful when we want to call the extension methods for a smart enum. --------- Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
This has to be done in parts, because the Roslyn importer runs out of memory otherwise. Which also means I have no idea how many parts there will end up being. Partial fix for #17399.
This has to be done in parts, because the Roslyn importer runs out of memory otherwise. Which also means I have no idea how many parts there will end up being. Partial fix for #17399.
This is a whitespace only change.
…#22352. (#22358) According to Apple's documentation, you're supposed to create an ASAccessorySession using the default constructor: https://developer.apple.com/documentation/accessorysetupkit/discovering-and-configuring-accessories?language=objc Fixes #22352.
Remove many options that aren't in use anymore.
…m xharness for tests. (#22361) This way it's set when building tests from the command line as well.
…#22376) That way we run as many tests as we can before completely failing.
…ndle. (#22366) Add the factory method to be used to generate the code needed to get a smart enum from a handle. --------- Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
Add the initial wiring to generate trampolines for the bindings. This change is not generating valid properties for Action, but is adding the needed wiring to start writing the trampolines. 1. Add the trampoline emitter. 2. Add the map/reduce code for the generator to pick trampolines to generate. 3. Update tests to be able to check that the trampolines are indeed generated. --------- Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
1. Use 'in' structures so that we do not have a copy of it, we are only reading the data. 2. Update some xml docs.
…From attr. (#22368) Put the pieces together to generate the code for properites with a BindFrom (NSString) and a smart enum. --------- Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
Use the same naming logic that we find in bgen but adapted to the data model that we use in rgen. Both the algorithm and the test are a copy of the bgen implementation so that the generated code uses the same naming conventions. --------- Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
… any IDE. (#22386) This is admittedly not very intuitive, which is a known issue: dotnet/msbuild#4751. Also regenerate the Resources.Designer.cs files accordingly.
This pull request updates the following dependencies ## Coherency Updates The following updates ensure that dependencies with a *CoherentParentDependency* attribute were produced in a build used as input to the parent dependency's build. See [Dependency Description Format](https://github.com/dotnet/arcade/blob/master/Documentation/DependencyDescriptionFormat.md#dependency-description-overview) - **Coherency Updates**: - **Microsoft.NET.ILLink.Tasks**: from 9.0.2 to 9.0.3 (parent: Microsoft.NET.Sdk) - **Microsoft.AspNetCore.App.Ref**: from 9.0.2 to 9.0.3 (parent: Microsoft.NET.Sdk) - **Microsoft.NETCore.App.Ref**: from 9.0.2 to 9.0.3 (parent: Microsoft.NET.Sdk) - **Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport**: from 9.0.2-servicing.25061.2 to 9.0.3-servicing.25105.2 (parent: Microsoft.NETCore.App.Ref) - **Microsoft.NETCore.App.Ref**: from 9.0.2 to 9.0.3 (parent: Microsoft.NET.Sdk) - **Microsoft.DotNet.Cecil**: from 0.11.5-alpha.25056.3 to 0.11.5-alpha.25102.5 (parent: Microsoft.NETCore.App.Ref) ## From https://github.com/dotnet/sdk - **Subscription**: a3af34df-ee86-4a08-b10d-b90bd4a87d76 - **Build**: [20250312.22](https://dev.azure.com/dnceng/internal/_build/results?buildId=2661520) - **Date Produced**: March 12, 2025 6:20:43 PM UTC - **Commit**: [2f3a515827610a95a8cfceba780f378293c9bec4](dotnet/sdk@2f3a515) - **Branch**: refs/heads/release/9.0.1xx - **Updates**: - **Microsoft.NET.Sdk**: [from 9.0.104-servicing.25111.36 to 9.0.105-servicing.25162.22][1] - **Microsoft.NET.ILLink.Tasks**: [from 9.0.2 to 9.0.3][2] - **Microsoft.AspNetCore.App.Ref**: [from 9.0.2 to 9.0.3][3] - **Microsoft.NETCore.App.Ref**: [from 9.0.2 to 9.0.3][2] - **Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport**: [from 9.0.2-servicing.25061.2 to 9.0.3-servicing.25105.2][4] - **Microsoft.NETCore.App.Ref**: [from 9.0.2 to 9.0.3][2] - **Microsoft.DotNet.Cecil**: [from 0.11.5-alpha.25056.3 to 0.11.5-alpha.25102.5][5] [1]: dotnet/sdk@346d06b...2f3a515 [2]: https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/branches?baseVersion=GC80aa709f5d919c6814726788dc6dabe23e79e672&targetVersion=GC831d23e56149cd59c40fc00c7feb7c5334bd19c4&_a=files [3]: https://dev.azure.com/dnceng/internal/_git/dotnet-aspnetcore/branches?baseVersion=GC704f7cb1d2cea33afb00c2097731216f121c2c73&targetVersion=GCb96167fbfe8bd45d94e4dcda42c7d09eb5745459&_a=files [4]: dotnet/emsdk@2c27e40...dad5528 [5]: dotnet/cecil@7ea2381...aa3ae0d
This pull request updates the following dependencies ## From https://github.com/dotnet/arcade - **Subscription**: 0ed7aa82-fff7-4048-943c-7b5fa7eed6f0 - **Build**: [20250311.4](https://dev.azure.com/dnceng/internal/_build/results?buildId=2660870) - **Date Produced**: March 12, 2025 1:06:33 AM UTC - **Commit**: [f33d9e642f0e68a61312164cd9e0baf4e142a999](dotnet/arcade@f33d9e6) - **Branch**: refs/heads/release/9.0 - **Updates**: - **Microsoft.DotNet.Arcade.Sdk**: [from 9.0.0-beta.25111.5 to 9.0.0-beta.25161.4][1] - **Microsoft.DotNet.Build.Tasks.Feed**: [from 9.0.0-beta.25111.5 to 9.0.0-beta.25161.4][1] [1]: dotnet/arcade@5da211e...f33d9e6 - **Updates to .NET SDKs:** - Updates sdk.version to 9.0.104 - Updates tools.dotnet to 9.0.104
rolfbjarne
requested review from
dalexsoto,
emaf,
mandel-macaque and
mauroa
as code owners
dalexsoto
approved these changes
Mar 19, 2025
This comment has been minimized.
This comment has been minimized.
Collaborator
✅ [PR Build #092ae43] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
Collaborator
✅ [CI Build #ddc7ab4] Build passed (Build packages) ✅Pipeline on Agent |
Collaborator
✅ [CI Build #092ae43] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
💻 [CI Build #092ae43] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
Collaborator
💻 [CI Build #092ae43] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
Collaborator
💻 [CI Build #092ae43] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
Collaborator
✅ API diff for current PR / commit.NET ( No breaking changes )❗ API diff vs stable (Breaking changes).NET ( ❗ Breaking changes ❗ )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) Unable to create gist: Response status code does not indicate success: 422 (Unprocessable Entity). (raw diff) - Please review changes) Pipeline on Agent |
Collaborator
❌ [CI Build #ddc7ab4] Windows Integration Tests failed ❌❌ Failed ❌ Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
🔥 [CI Build #092ae43] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 1 tests failed, 117 tests passed. Failures❌ windows testsDetailsHtml Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Collaborator
💻 [CI Build #092ae43] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.