Skip to content

Conversation

@mandel-macaque
Copy link
Contributor

Add a new method that will take a managed delegate parameter and will generate the needed parameter syntax for the Invoke and delegate in a trampoline.

Example of conversions:

Action -> IntrPtr
NSObject -> NativeHandle
Pointer -> Pointer
Array -> NativeHandle

The tests take care to verify that the correct conversions is done for all the known parameter types.

We need this conversion to fix the reviews in #22813

mandel-macaque and others added 2 commits May 19, 2025 13:25
…ampoline.

Add a new method that will take a managed delegate parameter and will
generate the needed parameter syntax for the Invoke and delegate in a
trampoline.

Example of conversions:

Action -> IntrPtr
NSObject -> NativeHandle
Pointer -> Pointer
Array -> NativeHandle

The tests take care to verify that the correct conversions is done for
all the known parameter types.
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #57c7a6e] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 57c7a6ece2ecf1bd6a96357f6e0c83bb4e67299e [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #8651389] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 865138949d81d5c12e2b9f630bb38197a4339385 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 57c7a6ece2ecf1bd6a96357f6e0c83bb4e67299e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #8651389] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 865138949d81d5c12e2b9f630bb38197a4339385 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build #8651389] Tests on macOS X64 - Mac Sonoma (14) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: 865138949d81d5c12e2b9f630bb38197a4339385 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #8651389] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 865138949d81d5c12e2b9f630bb38197a4339385 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #8651389] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 865138949d81d5c12e2b9f630bb38197a4339385 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #8651389] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 865138949d81d5c12e2b9f630bb38197a4339385 [PR build]

@mandel-macaque
Copy link
Contributor Author

Failing tests are unrelated to the code changes.

@mandel-macaque mandel-macaque merged commit c33c803 into main May 20, 2025
38 of 40 checks passed
@mandel-macaque mandel-macaque deleted the dev/mandel/typeinfo-get-low-level-identifier-type branch May 20, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants