[msbuild] Be explicit about string comparisons.#24513
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request makes string comparisons explicit in the ComputeCodesignItems.cs file by adding the StringComparison.OrdinalIgnoreCase parameter to a string.Equals call. This ensures that the comparison behavior is consistent and explicit, following the pattern already established elsewhere in the same file.
Changes:
- Added
StringComparison.OrdinalIgnoreCaseparameter tostring.Equalscall when checking ifenableCodeSigningequals "true"
✅ [CI Build #d86613f] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #d86613f] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #d86613f] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #d86613f] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #d86613f] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #d86613f] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #d86613f] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #d86613f] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #d86613f] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 119 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
No description provided.