Skip to content

Conversation

@rolfbjarne
Copy link
Member

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds validation to detect when an MSBuild task tries to execute an external process without having the SdkDevPath property set. This helps catch configuration errors earlier with a clear error message.

Changes:

  • Added error detection in ExecuteAsync to log an error when SdkDevPath is not set on macOS
  • Updated test infrastructure to automatically set SdkDevPath when creating XamarinTask instances
  • Added new error message E7164 to the localization resources

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
msbuild/Xamarin.MacDev.Tasks/Tasks/XamarinTask.cs Added validation to check for missing SdkDevPath before executing external processes, and changed ExecuteAsync signature to accept Task instead of TaskLoggingHelper
tests/msbuild/Xamarin.MacDev.Tasks.Tests/TestHelpers/TestBase.cs Updated CreateTask method to automatically set SdkDevPath for XamarinTask instances to prevent test failures
msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx Added new error message E7164 for missing SdkDevPath scenario

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne force-pushed the dev/rolf/msbuild-enforce-sdkdevpath branch from 018c9a4 to 9a3de6c Compare January 26, 2026 11:57
@rolfbjarne rolfbjarne marked this pull request as ready for review January 26, 2026 11:57
@rolfbjarne rolfbjarne changed the title [msbuild] Show an error if SdkDevPath hasn't been set and we're executing a process. [msbuild] Show a warning if SdkDevPath hasn't been set and we're executing a process. Jan 26, 2026
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne enabled auto-merge (squash) January 27, 2026 17:30
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #04809ad] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 04809adb3afb7aaf67956f0bb0a352bc80d31f0c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #04809ad] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 04809adb3afb7aaf67956f0bb0a352bc80d31f0c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 04809adb3afb7aaf67956f0bb0a352bc80d31f0c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #04809ad] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 04809adb3afb7aaf67956f0bb0a352bc80d31f0c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #04809ad] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 04809adb3afb7aaf67956f0bb0a352bc80d31f0c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #04809ad] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 04809adb3afb7aaf67956f0bb0a352bc80d31f0c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #04809ad] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 04809adb3afb7aaf67956f0bb0a352bc80d31f0c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #04809ad] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 04809adb3afb7aaf67956f0bb0a352bc80d31f0c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #04809ad] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 04809adb3afb7aaf67956f0bb0a352bc80d31f0c [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #04809ad] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 04809adb3afb7aaf67956f0bb0a352bc80d31f0c [PR build]

@rolfbjarne rolfbjarne merged commit a61decb into main Jan 27, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants