Skip to content

[UIKit] Enable nullability and clean up UIAccessibilityCustomAction.#24580

Merged
rolfbjarne merged 2 commits intomainfrom
dev/rolf/uikit-nullability-uiaccessibilitycustomaction-02
Jan 30, 2026
Merged

[UIKit] Enable nullability and clean up UIAccessibilityCustomAction.#24580
rolfbjarne merged 2 commits intomainfrom
dev/rolf/uikit-nullability-uiaccessibilitycustomaction-02

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Jan 29, 2026

This is file 2 of 30 files with nullability disabled in UIKit.

  • Enable nullability.
  • Use ArgumentNullException.ThrowIfNull() instead of manual null check.
  • Add nullable annotation (object?).
  • Improve XML documentation comments: remove 'To be added.' placeholders, fix typos, add missing docs, fix formatting.

Contributes towards #17285.

* Enable nullability (#nullable enable).
* Use ArgumentNullException.ThrowIfNull() instead of manual null check.
* Add nullable annotation (object?).
* Improve XML documentation comments: remove 'To be added.' placeholders, fix typos, add missing docs, fix formatting.

Contributes towards #17285.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables nullable reference types in UIAccessibilityCustomAction and updates the helper constructor/dispatcher to use modern null-checking while cleaning up XML documentation.

Changes:

  • Enabled #nullable and updated the action backing field to object?.
  • Replaced a manual null-check with ArgumentNullException.ThrowIfNull.
  • Improved XML documentation comments (removed placeholders, fixed formatting/typos).

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne enabled auto-merge (squash) January 30, 2026 10:33
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #cb80c4f] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: cb80c4f350206973314bf17bd6719760753e24ce [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #cb80c4f] Build passed (Build packages) ✅

Pipeline on Agent
Hash: cb80c4f350206973314bf17bd6719760753e24ce [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: cb80c4f350206973314bf17bd6719760753e24ce [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #cb80c4f] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: cb80c4f350206973314bf17bd6719760753e24ce [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #cb80c4f] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: cb80c4f350206973314bf17bd6719760753e24ce [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #cb80c4f] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: cb80c4f350206973314bf17bd6719760753e24ce [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #cb80c4f] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: cb80c4f350206973314bf17bd6719760753e24ce [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #cb80c4f] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: cb80c4f350206973314bf17bd6719760753e24ce [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #cb80c4f] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: cb80c4f350206973314bf17bd6719760753e24ce [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #cb80c4f] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: cb80c4f350206973314bf17bd6719760753e24ce [PR build]

@rolfbjarne rolfbjarne merged commit f1559ad into main Jan 30, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants