[CoreVideo] Expose CVPixelBufferAttributes.AllocateWithIOSurface|MetalCompatibility on macOS. Fixes #24584.#24590
Conversation
…lCompatibility on macOS. Fixes #24584. CVPixelBufferAttributes.AllocateWithIOSurface was initially exposed, but due to an incorrect merge conflict resolution got removed on macOS (xamarin/maccore@0feda2d). CVPixelBufferAttributes.MetalCompatibility was added to iOS first, and then a year later on macOS, but we never removed the macOS exclusion. Fixes #24584.
There was a problem hiding this comment.
Pull request overview
This PR fixes the availability of two CVPixelBufferAttributes properties on macOS that were incorrectly excluded due to past merge conflicts and incomplete updates.
Changes:
- Exposed
AllocateWithIOSurfaceproperty on macOS (was incorrectly removed in a merge conflict) - Exposed
MetalCompatibilityproperty on macOS (exclusion was never removed when macOS support was added) - Updated documentation for
AllocateWithIOSurfaceandOpenGLESCompatibilityproperties
✅ [CI Build #86d4754] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #86d4754] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #86d4754] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #86d4754] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #86d4754] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #86d4754] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #86d4754] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #86d4754] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #86d4754] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 126 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
CVPixelBufferAttributes.AllocateWithIOSurface was initially exposed, but due
to an incorrect merge conflict resolution got removed on macOS
(https://github.com/xamarin/maccore/commit/0feda2d8613a818c2e72c092a4cd8e5b20c5e88e).
CVPixelBufferAttributes.MetalCompatibility was added to iOS first, and then a
year later on macOS, but we never removed the macOS exclusion.
Fixes #24584.