[UIKit] Enable nullability and clean up UIImagePickerController.#24674
Conversation
This is file 13 of 30 files with nullability disabled in UIKit. * Enable nullability (#nullable enable). * Remove unused 'using System.Drawing' directive. * Add nullable annotations to properties returning reference types from dictionary lookups (UIImage?, NSUrl?, PHLivePhoto?, PHAsset?, NSDictionary?, string?). * Cast delegate setters to NSObject? for nullable correctness. * Improve XML documentation comments: remove 'To be added.' placeholders, add missing docs for ReferenceUrl and PHAsset, add 'see cref' references, use 'Gets' / 'Gets or sets' consistently, fix formatting. Contributes towards #17285.
There was a problem hiding this comment.
Pull request overview
Enables nullable reference types for UIImagePickerController’s manual partial and updates related event-args properties/docs to reflect nullable values coming from Info dictionary lookups.
Changes:
- Enabled
#nullableinUIImagePickerController.csand removed an unusedusing. - Annotated
UIImagePickerMediaPickedEventArgsproperties as nullable where values may be absent fromInfo. - Updated delegate wrapper properties to be nullable and adjusted delegate assignment casts accordingly; improved XML docs.
✅ [PR Build #7f8a8fc] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #7f8a8fc] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #7f8a8fc] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #7f8a8fc] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #7f8a8fc] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #7f8a8fc] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #7f8a8fc] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
💻 [CI Build #7f8a8fc] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #7f8a8fc] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 117 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This is file 13 of 30 files with nullability disabled in UIKit.
dictionary lookups (UIImage?, NSUrl?, PHLivePhoto?, PHAsset?,
NSDictionary?, string?).
add missing docs for ReferenceUrl and PHAsset, add 'see cref' references,
use 'Gets' / 'Gets or sets' consistently, fix formatting.
Contributes towards #17285.