Update MessagingVersion to 18.3.99-g08330b37ad#24870
Conversation
Brings fixes for building from Windows targeting a .NET version lower than the used to build (i.e., building with .NET 11 a project targeting net10.0-ios).
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This looks related to the bump. These are both tests related to using RuntimeIdentifiers (plural) vs RuntimeIdentifier in the project file. In that case, we do an inner build for each RuntimeIdentifier (singular), before we combine the result in the outer RuntimeIdentifiers build. The problem seems to stem from the fact that the inner builds now have their own session, and since the output path on the mac is session-specific, the outer build can't find the inner builds' output anymore. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@emaf doesn't look like that worked, the nested SayHello is still creating a new session. Sample binlog: https://vsdrop.corp.microsoft.com/file/v1/macios/device-tests/20260313.5/13545692/windows_integrationwindows-3/;tests/dotnet/MySimpleApp/iOS/log-build-20260316_023942.binlog |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@emaf I'm not quite sure how it's supposed to work now, but I see this from the nested SayHello task:
and then a little bit later (this is from the
The hashes don't match. |
✅ [PR Build #e62d6ce] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #e62d6ce] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #e62d6ce] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #e62d6ce] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Brings fixes for building from Windows targeting a .NET version lower than the used to build (i.e., building with .NET 11 a project targeting net10.0-ios).