[automated] Merge branch 'main' => 'net11.0'#25059
Conversation
[tests] Adjust full-chain trust expectations for 26.4 Update Security/TrustTest full-chain assertions to match platform 26.4 behavior while preserving older expectations. - Keep the default expected result as SecTrustResult.Unspecified. - For platform version 26.4+, expect SecTrustResult.RecoverableTrustFailure for the full-chain mail.google.com trust path. - Make the final trust.Evaluate(out error) assertions conditional on the expected trust result: - Unspecified => Evaluate succeeds and error is null. - RecoverableTrustFailure => Evaluate fails and error is non-null. This keeps legacy behavior unchanged and accepts the newer trust-evaluation outcome seen in 26.4 CI for Trust_FullChain and Trust2_FullChain. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> [tests] Stabilize monotouch CI on Xcode 26.4 CI build 13465051 showed monotouch regressions across iOS, tvOS, macOS, and Mac Catalyst with platform-specific symptoms that were either behavioral drift on 26.4 or flaky runtime conditions that made tests too strict. Observed failures from CI artifacts: - iOS/tvOS (many monotouch variations): - MonoTouchFixtures.Security.TrustTest.Trust_FullChain - MonoTouchFixtures.Security.TrustTest.Trust2_FullChain - MonoTouchFixtures.VideoToolbox.VTDecompressionSessionTests.DecodeFrameTest - iOS/macOS/Mac Catalyst: - MonoTests.System.Net.Http.MessageHandlerTest.SslCertificatesWithoutOCSPEndPointsNSUrlSessionHandler_AllowByDefault - MonoTests.System.Net.Http.MessageHandlerTest.SslCertificatesWithoutOCSPEndPointsNSUrlSessionHandler_Disallow - Previous macOS job triage also showed a native crash path in adaptive bitmap setup. This change set hardens those tests while preserving useful signal: 1) tests/common/TestRuntime.cs - Extend CheckXcodeVersion mappings for Xcode 26.x: - add case 26.3 (mapped to 26.2 SDK behavior) - add case 26.4 (mapped to OS version checks for each platform) - This prevents version-gate logic from throwing NotImplementedException when tests use 26.4 checks. 2) tests/monotouch-test/CoreGraphics/BitmapContextTest.cs (CreateAdaptive_2) - Replace fixed rendering buffer size (512) with computed size from adaptive parameters: - parameters.AlignedBytesPerRow * parameters.Height - Allocate native memory using the computed size as well. - This avoids under-sized backing buffers and reduces crash risk in adaptive ToImage paths. 3) tests/monotouch-test/Security/TrustTest.cs (Trust_FullChain / Trust2_FullChain path) - On platform version 26.4+, accept either trust result: - SecTrustResult.Unspecified - SecTrustResult.RecoverableTrustFailure - Keep strict Unspecified expectation on earlier versions. - Align subsequent GetTrustResult assertion with the actual evaluate result. - Make final Evaluate(out error) assertion branch off the observed result and fail explicitly for unexpected trust states. - This addresses 26.4 behavior variance seen in CI between runs/platforms. 4) tests/monotouch-test/VideoToolbox/VTDecompressionSessionTests.cs (DecodeFrameTest) - Detect known callback status -8969 on iOS/tvOS 26.4 and treat it as known platform instability for this test. - Keep hard failure behavior for other non-OK callback statuses. - Mark the test inconclusive when this known status is observed instead of failing. - This keeps the test informative while preventing false negatives from decoder instability. 5) tests/monotouch-test/System.Net.Http/MessageHandlers.cs - Harden OCSP-endpoint validation tests for NSUrlSessionHandler by adding retry logic (up to 3 attempts) when callback execution is flaky. - Preserve strict assertions when callback is executed. - If callback is still not called after retries, mark inconclusive instead of hard-fail. - Keep timeout/bad-network handling behavior consistent with CI-friendly test patterns. Validation performed locally: - Targeted iOS/tvOS runs for trust/decode/http monotouch failures: no failures. - Targeted macOS/Mac Catalyst NSUrlSessionHandler OCSP tests: no failures (pass/inconclusive outcomes only). - macOS disallow-case stress (10x): no failures (pass/inconclusive only). - Mac Catalyst x64 monotouch run previously validated after adaptive buffer fix. Net effect: - Removes hard CI failures caused by 26.4 behavior drift and intermittent callback/decoder instability, while retaining coverage and surfacing flaky conditions as inconclusive. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Fix brittle Trust_FullChain test expectation on iOS 16.4+ The Trust_FullChain test assumed that if the initial trust evaluation returned RecoverableTrustFailure, subsequent evaluations after setting anchor certificates would also fail (return false). However, on newer iOS versions (16.4+), setting the correct full chain as anchors can result in a successful evaluation (true). This change updates the test to allow success in this scenario, while still ensuring that if it fails, an error is present. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
No API changes, also moving away from dl.internalx --------- Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…NSUrlSessionHandler (#24957) Add an opt-out switch 'Foundation.NSUrlSessionHandler.KeepHeadersAfterDecompression' that, when enabled, preserves the original Content-Encoding and Content-Length headers on auto-decompressed responses instead of removing them. This allows apps that depend on the original headers to restore the previous behavior. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ts (#24970) The Windows integration BGen tests were failing with 151 errors because the XCODE_26_4_PREVIEW diagnostic was not being suppressed during compilation. Root cause: On Windows, the generated test-system.config file (which contains XCODE_IS_STABLE=false) doesn't exist. The fallback parser in Configuration.cs reads Make.config but can't interpret Makefile conditionals (ifeq/else/endif), so it incorrectly picks up XCODE_IS_STABLE=true from the wrong branch. This causes BGenTool.GetPreviewNoWarn() to skip adding --nowarn:XCODE_26_4_PREVIEW, and the compiler errors on all Foundation type references marked with [assembly: Experimental("XCODE_26_4_PREVIEW")]. Fix: Flow XCODE_VERSION and XCODE_IS_STABLE through the full CI pipeline from the macOS configure stage to the Windows test environment: - configure-platforms.sh: export both variables - VSTS.psm1 Create(): store in configuration.json artifact - VSTS.psm1 Import(): export as pipeline output variables - run-generator-tests-on-windows.ps1: set as environment variables --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This will eventually become 27.0, when .NET 11 goes stable (for now there's no Xcode 26.0 support in .NET 11, only Xcode 26.4).
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #4126003] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #4126003] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #4126003] Build passed (Build macOS tests) ✅Pipeline on Agent |
🚀 [CI Build #4126003] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 161 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
I detected changes in the main branch which have not been merged yet to net11.0. I'm a robot and am configured to help you automatically keep net11.0 up to date, so I've opened this PR.
This PR merges commits made on main by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/main-to-net11.0'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.
or if you are using SSH
Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.