[tests] Make NSStreamTest.ConnectToPeer time out cleanly.#25091
[tests] Make NSStreamTest.ConnectToPeer time out cleanly.#25091rolfbjarne merged 2 commits intomainfrom
Conversation
As opposed to hanging the entire test suite (and then getting aborted) if something goes wrong. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the NSStreamTest.ConnectToPeer monotouch test to fail with a bounded timeout instead of potentially hanging the entire test run, improving reliability of the test suite when networking/stream setup goes wrong.
Changes:
- Run the ConnectToPeer logic on a background thread and enforce a 10s overall timeout.
- Add a bounded join (5s) for the listener thread and propagate any exceptions back to the main test thread.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
✅ [CI Build #9ff2da9] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #9ff2da9] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #9ff2da9] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #9ff2da9] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
As opposed to hanging the entire test suite (and then getting aborted) if something goes wrong.