[dotnet-linker] Create an xml descriptor instead of manual marking when applying the [Preserve] attribute. by rolfbjarne · Pull Request #25109 · dotnet/macios

rolfbjarne · 2026-04-07T18:12:21Z

Create an xml descriptor file instead of manually marking when applying the [Preserve] attribute.

I first tried using [DynamicDependency] attributes, but it turns out [DynamicDependency] attributes can't accurately express/replace [Preserve] semantics, so I went with an xml descriptor file instead.

The [DynamicDependency] attribute code is still present, as an opt-in, because it was already there used for NativeAOT (even though we're always using the xml descriptor logic now, even for NativeAOT).

This makes it easier to move this code out of a custom linker step in the future.

Also move the removal of any [Preserve] attributes to the RemoveAttributes step.

Contributes towards #17693.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

tools/dotnet-linker/ApplyPreserveAttributeStep.cs

tools/dotnet-linker/AppBundleRewriter.cs

tools/dotnet-linker/ApplyPreserveAttributeStep.cs

azure-pipelines · 2026-04-13T10:13:27Z

Azure Pipelines: 2 pipeline(s) require an authorized user to comment /azp run to run.

azure-pipelines · 2026-04-13T18:35:03Z

Azure Pipelines: 2 pipeline(s) require an authorized user to comment /azp run to run.

…en applying the [Preserve] attribute. Create an xml descriptor file instead of manually marking when applying the [Preserve] attribute. I first tried using [DynamicDependency] attributes, but it turns out [DynamicDependency] attributes can't accurately express/replace [Preserve] semantics, so I went with an xml descriptor file instead. The [DynamicDependency] attribute code is still present, as an opt-in, because it was already there used for NativeAOT (even though we're always using the xml descriptor logic now, even for NativeAOT). This makes it easier to move this code out of a custom linker step in the future. Also move the removal of any [Preserve] attributes to the RemoveAttributes step. Contributes towards #17693.

azure-pipelines · 2026-04-14T08:15:50Z

Azure Pipelines: 2 pipeline(s) require an authorized user to comment /azp run to run.

vs-mobiletools-engineering-service2 · 2026-04-14T08:43:57Z

✅ [CI Build #a573a2e] Build passed (Build packages) ✅

Pipeline on Agent
Hash: a573a2e3882af03157ad600461e65baea9ba802a [PR build]

vs-mobiletools-engineering-service2 · 2026-04-14T08:48:11Z

✅ [PR Build #a573a2e] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: a573a2e3882af03157ad600461e65baea9ba802a [PR build]

vs-mobiletools-engineering-service2 · 2026-04-14T09:00:39Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: a573a2e3882af03157ad600461e65baea9ba802a [PR build]

vs-mobiletools-engineering-service2 · 2026-04-14T09:10:47Z

✅ [CI Build #a573a2e] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: a573a2e3882af03157ad600461e65baea9ba802a [PR build]

vs-mobiletools-engineering-service2 · 2026-04-14T10:09:40Z

🚀 [CI Build #a573a2e] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 156 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: a573a2e3882af03157ad600461e65baea9ba802a [PR build]

rolfbjarne requested a review from Copilot April 7, 2026 18:12

Copilot started reviewing on behalf of rolfbjarne April 7, 2026 18:13 View session

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

rolfbjarne force-pushed the dev/rolf/use-xml-descriptor-applypreserveattribute branch from 7c5da69 to 838cd8d Compare April 8, 2026 06:23

rolfbjarne requested a review from Copilot April 8, 2026 06:23

Copilot started reviewing on behalf of rolfbjarne April 8, 2026 06:24 View session

rolfbjarne mentioned this pull request Apr 8, 2026

[dotnet-linker] Use [DynamicDependency] attributes instead of manual marking when applying the [Preserve] attribute. #25001

Closed

Copilot AI reviewed Apr 8, 2026

View reviewed changes

tools/dotnet-linker/ApplyPreserveAttributeStep.cs Outdated Show resolved Hide resolved

tools/dotnet-linker/AppBundleRewriter.cs Show resolved Hide resolved

tools/dotnet-linker/ApplyPreserveAttributeStep.cs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Apr 9, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits April 14, 2026 09:41

Update sizes.

a573a2e

rolfbjarne force-pushed the dev/rolf/use-xml-descriptor-applypreserveattribute branch from 1dcbffe to a573a2e Compare April 14, 2026 08:15

rolfbjarne merged commit 9639042 into main Apr 14, 2026
48 checks passed

Conversation

rolfbjarne commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

azure-pipelines bot commented Apr 13, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

azure-pipelines bot commented Apr 13, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

azure-pipelines bot commented Apr 14, 2026

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 14, 2026

✅ [CI Build #a573a2e] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 14, 2026

✅ [PR Build #a573a2e] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 14, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 14, 2026

✅ [CI Build #a573a2e] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 14, 2026

🚀 [CI Build #a573a2e] Test results 🚀

Test results

Tests counts

macOS tests

Linux Build Verification

Uh oh!

Uh oh!

rolfbjarne commented Apr 7, 2026 •

edited

Loading