Skip to content

Remove duplicate entries in Directory.Build.props.#25126

Merged
rolfbjarne merged 1 commit intomainfrom
dev/rolf/no-dupl-dupl-props
Apr 13, 2026
Merged

Remove duplicate entries in Directory.Build.props.#25126
rolfbjarne merged 1 commit intomainfrom
dev/rolf/no-dupl-dupl-props

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

Only keep the highest version for each entry.

Only keep the highest version for each entry.
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up Directory.Build.props by removing duplicate package-version properties so that each package version is defined exactly once (keeping the highest version).

Changes:

  • Removed duplicate MonoCecilPackageVersion, NUnitPackageVersion, NUnit3TestAdapterPackageVersion, and MicrosoftNETTestSdkPackageVersion properties.
  • Standardized the effective versions to: Mono.Cecil 0.11.6, NUnit 4.4.0, NUnit3TestAdapter 6.1.0, Microsoft.NET.Test.Sdk 18.0.1.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #977303a] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 977303a99a88cf01fa5c30a4529e7ece3cec6a2a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [PR Build #977303a] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 977303a99a88cf01fa5c30a4529e7ece3cec6a2a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 977303a99a88cf01fa5c30a4529e7ece3cec6a2a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #977303a] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 977303a99a88cf01fa5c30a4529e7ece3cec6a2a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

🚀 [CI Build #977303a] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 156 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: 977303a99a88cf01fa5c30a4529e7ece3cec6a2a [PR build]

@rolfbjarne rolfbjarne enabled auto-merge (squash) April 13, 2026 07:55
@rolfbjarne rolfbjarne merged commit 3b265d6 into main Apr 13, 2026
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants