Skip to content

[PrintCore] Update bindings and clear xtro#25128

Merged
dalexsoto merged 2 commits into
xcode26.5from
dev/alex/xc26.5-PrintCore
Apr 13, 2026
Merged

[PrintCore] Update bindings and clear xtro#25128
dalexsoto merged 2 commits into
xcode26.5from
dev/alex/xc26.5-PrintCore

Conversation

@dalexsoto
Copy link
Copy Markdown
Member

No description provided.

@dalexsoto dalexsoto added this to the xcode26.5 milestone Apr 9, 2026
@dalexsoto dalexsoto requested a review from rolfbjarne as a code owner April 9, 2026 14:09
Comment thread src/printcore.cs Outdated
/// </returns>
[Abstract]
[Export ("printSession")]
IntPtr GetPrintSession ();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using IPMPrintSession should work I think?

Suggested change
IntPtr GetPrintSession ();
IPMPrintSession GetPrintSession ();

and the same for the other methods here

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Comment thread src/printcore.cs
/// A pointer to the native <c>ppd_file_s</c> CUPS PPD structure for the current printer.
/// </returns>
[Abstract]
[Export ("ppdFile")]
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CUPS PPD API is deprecated since OSX 10.6 so not sure there is value in providing a managed shim here

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #4498bf4] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 4498bf400d648cf521d257985addede5965c4088 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@dalexsoto dalexsoto requested a review from rolfbjarne April 9, 2026 20:19
@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #4498bf4] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 4498bf400d648cf521d257985addede5965c4088 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [PR Build #4498bf4] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 4498bf400d648cf521d257985addede5965c4088 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 4498bf400d648cf521d257985addede5965c4088 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

🚀 [CI Build #4498bf4] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 158 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: 4498bf400d648cf521d257985addede5965c4088 [PR build]

@dalexsoto dalexsoto enabled auto-merge (squash) April 10, 2026 04:23
@dalexsoto dalexsoto merged commit 65fa8c2 into xcode26.5 Apr 13, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants