Skip to content

[msbuild] Ignore CS1685 in Xamarin.MacDev.Tasks tests.#25130

Merged
rolfbjarne merged 1 commit intomainfrom
dev/rolf/msbuild-fix-warning
Apr 13, 2026
Merged

[msbuild] Ignore CS1685 in Xamarin.MacDev.Tasks tests.#25130
rolfbjarne merged 1 commit intomainfrom
dev/rolf/msbuild-fix-warning

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

Also treat all warnings as errors, since this project is now warning-free.

Also treat all warnings as errors, since this project is now warning-free.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Xamarin.MacDev.Tasks MSBuild test project configuration to suppress a known compiler warning from ILMerged task assemblies and to enforce a warning-free build by promoting warnings to errors.

Changes:

  • Add CS1685 to NoWarn to ignore the duplicate ImmutableArray<T> warning.
  • Enable <TreatWarningsAsErrors>true</TreatWarningsAsErrors> (replacing the previous WarningsAsErrors=Nullable behavior).

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #c5304fe] Build passed (Build packages) ✅

Pipeline on Agent
Hash: c5304fef4f0cbe99940f0b4069ef0defa5524f7f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [PR Build #c5304fe] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: c5304fef4f0cbe99940f0b4069ef0defa5524f7f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c5304fef4f0cbe99940f0b4069ef0defa5524f7f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #c5304fe] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: c5304fef4f0cbe99940f0b4069ef0defa5524f7f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

🚀 [CI Build #c5304fe] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 156 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: c5304fef4f0cbe99940f0b4069ef0defa5524f7f [PR build]

@rolfbjarne rolfbjarne merged commit c90975a into main Apr 13, 2026
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants