[Foundation] Clean up pre-net10.0 code from NSUrlSessionHandler.#25177
[Foundation] Clean up pre-net10.0 code from NSUrlSessionHandler.#25177rolfbjarne merged 1 commit intomainfrom
Conversation
NET10_0_OR_GREATER is always set now, so remove other code paths.
There was a problem hiding this comment.
Pull request overview
Removes legacy pre-.NET 10 conditional code paths from NSUrlSessionHandler, on the basis that NET10_0_OR_GREATER is now always defined for the repo’s supported builds.
Changes:
- Deleted
ServicePointManager.SecurityProtocol→NSUrlSessionConfigurationTLS mapping code guarded by pre-.NET 10 defines. - Removed legacy iOS background-notification observer logic and the related
BypassBackgroundSessionCheckbacking field/behavior. - Simplified
BypassBackgroundSessionCheckto a consistently ignored/obsolete API surface.
✅ [CI Build #b3223c4] Build passed (Build packages) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #b3223c4] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #b3223c4] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
The pull request #25177 ran the PR pipeline twice: * https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=13868591&view=results * https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=13868592&view=results when there should be only one. So I asked Copilot, which said: It was triggered twice because two different Azure triggers fired for the same change. - 13868591 was queued as individualCI for refs/heads/dev/rolf/nsurlsession-cleanup on commit b3223c4. - 13868592 was queued seconds later as pullRequest for refs/pull/25177/merge on the synthetic merge commit 7fccb8c. That matches the repo’s PR pipeline config in tools/devops/automation/build-pull-request.yml, which has both a branch trigger: for refs/heads/dev/* and a pr: trigger for '*'. So opening/updating PR #25177 caused one normal branch CI run and one PR-validation run. So disable the branched-based trigger.
🚀 [CI Build #b3223c4] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
The pull request #25177 ran the PR pipeline twice: * https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=13868591&view=results * https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=13868592&view=results when it should only have been done once. So I asked Copilot, which said: It was triggered twice because two different Azure triggers fired for the same change. - 13868591 was queued as individualCI for refs/heads/dev/rolf/nsurlsession-cleanup on commit b3223c4. - 13868592 was queued seconds later as pullRequest for refs/pull/25177/merge on the synthetic merge commit 7fccb8c. That matches the repo’s PR pipeline config in tools/devops/automation/build-pull-request.yml, which has both a branch trigger: for refs/heads/dev/* and a pr: trigger for '*'. So opening/updating PR #25177 caused one normal branch CI run and one PR-validation run. So disable the branched-based trigger.
NET10_0_OR_GREATER is always set now, so remove other code paths.