[monotouch-test] Remove versioned code that's become dead due to min macOS version increasing.#25181
Conversation
Remove obsolete pre-macOS-12 checks from the macOS monotouch tests and collapse the dead branches to the behavior we now always run with. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Drop the empty macOS assert helpers, remove their remaining callers, and delete the setup methods that became empty afterward. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Removes legacy macOS-version-specific branches and skips in the monotouch-test suite that are now unreachable given the repo’s increased minimum macOS version.
Changes:
- Eliminated macOS 10.x conditional assertions/branches and related helper APIs (
AssertsMacYosemite/Mavericks helpers). - Simplified expected values and feature gates in tests where macOS version checks were previously required.
- Removed a few macOS-only test setup skips now made redundant by the minimum supported macOS version.
Reviewed changes
Copilot reviewed 57 out of 57 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/monotouch-test/System.Net.Http/MessageHandlers.cs | Removes macOS 10.10-specific ignore logic for NSUrlSessionHandler tests. |
| tests/monotouch-test/SpriteKit/SKScene.cs | Drops Mavericks-era setup gating from SpriteKit tests. |
| tests/monotouch-test/Security/TrustTest.cs | Collapses macOS version-dependent trust expectations/feature flags to current baseline behavior. |
| tests/monotouch-test/Security/SecureTransportTest.cs | Removes old macOS minimum checks and legacy datagram-size branching. |
| tests/monotouch-test/Security/PolicyTest.cs | Removes macOS 10.9+ runtime asserts and obsolete property-count special-casing. |
| tests/monotouch-test/Security/KeyTest.cs | Simplifies macOS-version-dependent expectations for key algorithms and status codes. |
| tests/monotouch-test/Security/KeyChainTest.cs | Removes pre-10.9 macOS behavior branch for SecItemAdd expectations. |
| tests/monotouch-test/SceneKit/SceneKit.cs | Removes Yosemite/64-bit setup gating now redundant for supported macOS. |
| tests/monotouch-test/SceneKit/SCNWorld.cs | Removes Mavericks/Yosemite setup gating from SceneKit tests. |
| tests/monotouch-test/SceneKit/SCNView.cs | Removes Yosemite/64-bit setup gating. |
| tests/monotouch-test/SceneKit/SCNScene.cs | Removes Yosemite/64-bit setup gating. |
| tests/monotouch-test/SceneKit/SCNNode.cs | Removes Mavericks/Yosemite setup gating from specific SceneKit tests. |
| tests/monotouch-test/SceneKit/SCNMaterial.cs | Removes Mavericks/64-bit setup gating. |
| tests/monotouch-test/SceneKit/SCNGeometrySource.cs | Removes legacy OS gating and enum filtering logic that only applied to very old macOS versions. |
| tests/monotouch-test/SceneKit/NodeTest.cs | Removes macOS 10.8 minimum assertion from SceneKit node test. |
| tests/monotouch-test/SceneKit/ActionTest.cs | Removes macOS 10.10 minimum assertion from setup. |
| tests/monotouch-test/ObjCRuntime/DelegateAndDataSourceTest.cs | Simplifies 32-bit skip condition after removing El Capitan helper. |
| tests/monotouch-test/NetworkExtension/VpnManagerTest.cs | Removes macOS 10.11 gating and hardcodes feature availability for macOS baseline. |
| tests/monotouch-test/MultipeerConnectivity/SessionTest.cs | Removes macOS 10.10/10.11 gates and simplifies encryption preference logic for macOS. |
| tests/monotouch-test/ModelIO/MDLMesh.cs | Removes macOS 10.12 bounding-box expectation split. |
| tests/monotouch-test/MetalPerformanceShaders/MPSImageNormalizedHistogramTests.cs | Removes macOS 10.13/10.14 conditional handling in constructor test. |
| tests/monotouch-test/MapKit/PinAnnotationViewTest.cs | Removes macOS 10.12 branch for PinTintColor expectation. |
| tests/monotouch-test/GameKit/LeaderboardViewControllerTest.cs | Removes macOS version gating and leaves the macOS test path inconclusive due to nil init. |
| tests/monotouch-test/GameKit/LeaderboardTest.cs | Removes macOS 10.8/10.9/10.10 feature gates and asserts. |
| tests/monotouch-test/Foundation/UrlSessionConfigurationTest.cs | Removes macOS 10.9/10.10 gating and simplifies feature flags for macOS baseline. |
| tests/monotouch-test/Foundation/UrlProtocolTest.cs | Removes macOS 10.9 bot workaround and legacy callback-path logic. |
| tests/monotouch-test/Foundation/UrlCredentialTest.cs | Removes pre-10.8 macOS persistence expectation branch. |
| tests/monotouch-test/Foundation/ObjectTest.cs | Removes macOS 10.10 gating around SecAccessControl availability in test. |
| tests/monotouch-test/Foundation/NSMutableDictionary2Test.cs | Removes pre-10.8 macOS mutable-copy expectation branch. |
| tests/monotouch-test/Foundation/NSLinguisticAnalysisTest.cs | Removes pre-10.9 macOS word-count expectation branches. |
| tests/monotouch-test/CoreImage/ImageTest.cs | Removes macOS 10.8/10.11 gating in CoreImage tests. |
| tests/monotouch-test/CoreFoundation/UrlTest.cs | Removes macOS 10.9 conditional for file URL string expectation. |
| tests/monotouch-test/CoreFoundation/DispatchTests.cs | Removes macOS 10.10 gating for default global queue label expectation. |
| tests/monotouch-test/CoreData/ManagedObjectContextTest.cs | Replaces runtime macOS version branching with compile-time MONOMAC expectation. |
| tests/monotouch-test/CoreBluetooth/UuidTest.cs | Removes macOS 10.10 gating and always runs those assertions on MONOMAC. |
| tests/monotouch-test/AssertsMac.cs | Deletes Yosemite/Mavericks-era helpers, leaving only availability-attribute skip helper. |
| tests/monotouch-test/AppKit/NSVisualEffectView.cs | Removes Yosemite-era setup gating. |
| tests/monotouch-test/AppKit/NSViewController.cs | Removes Yosemite-era setup gating. |
| tests/monotouch-test/AppKit/NSView.cs | Removes Yosemite-era setup gating. |
| tests/monotouch-test/AppKit/NSToolbar.cs | Removes Yosemite-era setup gating. |
| tests/monotouch-test/AppKit/NSTextView.cs | Removes Yosemite-era setup gating. |
| tests/monotouch-test/AppKit/NSTextField.cs | Removes Yosemite-era setup gating. |
| tests/monotouch-test/AppKit/NSTableRowView.cs | Removes Yosemite-era setup gating. |
| tests/monotouch-test/AppKit/NSTableColumn.cs | Removes Yosemite-era setup gating. |
| tests/monotouch-test/AppKit/NSTabViewItem.cs | Removes Yosemite-era setup gating. |
| tests/monotouch-test/AppKit/NSTabViewController.cs | Removes Yosemite-era setup gating. |
| tests/monotouch-test/AppKit/NSStoryboardSegue.cs | Removes Yosemite-era setup gating. |
| tests/monotouch-test/AppKit/NSStackView.cs | Removes Mavericks-era setup gating. |
| tests/monotouch-test/AppKit/NSSplitViewItem.cs | Removes Yosemite-era setup gating. |
| tests/monotouch-test/AppKit/NSSplitViewController.cs | Removes Yosemite-era setup gating. |
| tests/monotouch-test/AppKit/NSPathControlItem.cs | Removes Yosemite-era setup gating. |
| tests/monotouch-test/AppKit/NSPathControl.cs | Removes Yosemite-era setup gating across multiple tests. |
| tests/monotouch-test/AppKit/NSImage.cs | Removes Mountain Lion/Yosemite setup gating. |
| tests/monotouch-test/AppKit/NSControl.cs | Removes Yosemite-era setup gating. |
| tests/monotouch-test/AppKit/NSClipView.cs | Removes Mavericks-era setup gating. |
| tests/monotouch-test/AppKit/NSAppearance.cs | Removes Yosemite-era setup gating. |
| tests/monotouch-test/AVFoundation/AVAudioIONode.cs | Removes Yosemite-era setup gating. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Restore the runtime platform/version check in ManagedObjectContextTest so Mac Catalyst keeps the expected UndoManager behavior while macOS still uses the newer path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #89f319e] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #89f319e] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #89f319e] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #89f319e] Test results 🔥Test results❌ Tests failed on VSTS: test results 1 tests crashed, 0 tests failed, 151 tests passed. Failures❌ Tests on macOS Monterey (12) tests🔥 Failed catastrophically on VSTS: test results - mac_monterey (no summary found). Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
No description provided.