[StoreKit] Fix StoreKit iTunes identifier width. Fixes #25219.#25221
[StoreKit] Fix StoreKit iTunes identifier width. Fixes #25219.#25221rolfbjarne merged 4 commits intomainfrom
Conversation
Keep StoreProductParameters and related StoreKit numeric identifiers on long values so App Store IDs above Int32.MaxValue compile and round-trip correctly. Fixes #25219. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates StoreProductParameters to support App Store/iTunes identifiers larger than Int32.MaxValue, and adds regression tests to ensure 64-bit values round-trip correctly through the underlying dictionary.
Changes:
- Added a 64-bit iTunes identifier API surface to
StoreProductParameters(constructor + property backed byGetLongValue/SetNumberValue). - Added new StoreKit unit tests validating 64-bit identifier round-tripping and legacy behavior (where applicable).
- Extended
DictionaryContainertests to cover storing/removinglong?numeric values.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/monotouch-test/StoreKit/StoreProductParametersTest.cs | Adds tests for 64-bit identifier round-trip + legacy behavior under !XAMCORE_5_0. |
| tests/monotouch-test/Foundation/DictionaryContainerTest.cs | Adds coverage for setting/removing long? number values in DictionaryContainer. |
| src/StoreKit/StoreProductParameters.cs | Introduces 64-bit identifier support and wires it to GetLongValue/SetNumberValue. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #209830f] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #209830f] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #209830f] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #209830f] Test results 🔥Test results❌ Tests failed on VSTS: test results 1 tests crashed, 0 tests failed, 151 tests passed. Failures❌ Tests on macOS Monterey (12) tests🔥 Failed catastrophically on VSTS: test results - mac_monterey (no summary found). Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
Keep StoreProductParameters and related StoreKit numeric identifiers on long values
so App Store IDs above Int32.MaxValue compile and round-trip correctly.
Fixes #25219.