fix: treat missing expected cookie as transient network failure in TestNSurlSessionHandlerCookieContainerSetCookie by Copilot · Pull Request #25420 · dotnet/macios

Copilot · 2026-05-13T09:53:14Z

Fix TestNSurlSessionHandlerCookieContainerSetCookie to treat missing expected cookie as transient network failure (ignore in CI)
Address race condition: move CookieContainer inspection after !completed guard to avoid concurrent access
Address exception masking: separate !completed and !hasExpectedCookie CI-ignore guards so real exceptions still fail the test

…stNSurlSessionHandlerCookieContainerSetCookie Agent-Logs-Url: https://github.com/dotnet/macios/sessions/08f85733-39b4-40c6-bcf5-d46ae2c50f48 Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>

Copilot

Pull request overview

This PR adjusts a flaky network-dependent test (TestNSurlSessionHandlerCookieContainerSetCookie) to treat “request completed but expected cookie missing” as a transient CI failure, reducing spurious macOS CI failures in the System.Net.Http test suite.

Changes:

Precomputes whether the expected cookie was stored in the CookieContainer after the async request.
Expands the CI ignore guard to include missing-cookie cases in addition to timeouts.
Reuses the computed boolean in the final assertion.

rolfbjarne · 2026-05-13T10:45:34Z

@copilot address the comments

…HandlerCookieContainerSetCookie Agent-Logs-Url: https://github.com/dotnet/macios/sessions/269d09e0-2844-4dfa-9c95-470afec2eead Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>

Copilot · 2026-05-13T10:47:15Z

@copilot address the comments

Addressed both review comments in 883e89e:

Race condition: CookieContainer is now only accessed after the !completed CI-ignore guard (and Assert.IsTrue(completed)), so we only read it when the async task has actually finished.
Exception masking: Split into two separate guards — !completed first, then ex is asserted null, then !hasExpectedCookie — so a real exception still fails the test rather than being silently ignored.

vs-mobiletools-engineering-service2 · 2026-05-13T11:04:47Z

✅ [PR Build #883e89e] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 883e89e18404044b4a2eaed5220a13a8b58703d2 [PR build]

vs-mobiletools-engineering-service2 · 2026-05-13T11:11:31Z

✅ [PR Build #883e89e] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 883e89e18404044b4a2eaed5220a13a8b58703d2 [PR build]

vs-mobiletools-engineering-service2 · 2026-05-13T11:18:24Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 883e89e18404044b4a2eaed5220a13a8b58703d2 [PR build]

vs-mobiletools-engineering-service2 · 2026-05-13T11:30:24Z

✅ [PR Build #883e89e] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 883e89e18404044b4a2eaed5220a13a8b58703d2 [PR build]

vs-mobiletools-engineering-service2 · 2026-05-13T13:45:57Z

🚀 [CI Build #883e89e] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 175 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. (⚠️ Html Report Publish failed ⚠️) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. (⚠️ Html Report Publish failed ⚠️) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 16 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 16 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 883e89e18404044b4a2eaed5220a13a8b58703d2 [PR build]

Initial plan

1727968

Copilot AI assigned Copilot and rolfbjarne May 13, 2026

Copilot started work on behalf of rolfbjarne May 13, 2026 09:53 View session

Copilot AI linked an issue May 13, 2026 that may be closed by this pull request

[CI Postmortem] Flaky: TestNSurlSessionHandlerCookieContainerSetCookies on macOS #25385

Closed

Copilot AI changed the title ~~[WIP] Fix flaky test NSurlSessionHandlerCookieContainerSetCookies on macOS~~ fix: treat missing expected cookie as transient network failure in TestNSurlSessionHandlerCookieContainerSetCookie May 13, 2026

Copilot finished work on behalf of rolfbjarne May 13, 2026 09:56

Copilot AI requested a review from rolfbjarne May 13, 2026 09:56

This comment has been minimized.

Sign in to view

rolfbjarne marked this pull request as ready for review May 13, 2026 10:18

Copilot AI review requested due to automatic review settings May 13, 2026 10:18

rolfbjarne approved these changes May 13, 2026

View reviewed changes

rolfbjarne enabled auto-merge (squash) May 13, 2026 10:18

Copilot started reviewing on behalf of rolfbjarne May 13, 2026 10:18 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

Comment thread tests/monotouch-test/System.Net.Http/MessageHandlers.cs Outdated

Comment thread tests/monotouch-test/System.Net.Http/MessageHandlers.cs Outdated

This comment has been minimized.

Sign in to view

Copilot started work on behalf of rolfbjarne May 13, 2026 10:45 View session

fix: address race condition and exception-masking in TestNSurlSession…

883e89e

…HandlerCookieContainerSetCookie Agent-Logs-Url: https://github.com/dotnet/macios/sessions/269d09e0-2844-4dfa-9c95-470afec2eead Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>

auto-merge was automatically disabled May 13, 2026 10:47
Head branch was pushed to by a user without write access

This comment has been minimized.

Sign in to view

Copilot finished work on behalf of rolfbjarne May 13, 2026 10:48

Copilot AI requested a review from rolfbjarne May 13, 2026 10:48

This comment has been minimized.

Sign in to view

rolfbjarne enabled auto-merge (squash) May 13, 2026 11:17

dalexsoto approved these changes May 13, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 2daba49 into main May 13, 2026
45 checks passed

rolfbjarne deleted the copilot/fix-flaky-test-nsurlsessionhandler branch May 13, 2026 13:46

Conversation

Copilot AI commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented May 13, 2026

Uh oh!

Copilot AI commented May 13, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 13, 2026

✅ [PR Build #883e89e] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 13, 2026

✅ [PR Build #883e89e] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 13, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented May 13, 2026

✅ [PR Build #883e89e] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 13, 2026

🚀 [CI Build #883e89e] Test results 🚀

Test results

Tests counts

macOS tests

Linux Build Verification

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented May 13, 2026 •

edited

Loading