[AVFoundation] Fix signature for LoadTrack*/LoadTracks* methods. Fixes #25606#25653
[AVFoundation] Fix signature for LoadTrack*/LoadTracks* methods. Fixes #25606#25653rolfbjarne wants to merge 3 commits into
Conversation
…ixes #25606. Fix the completion handler parameter types for LoadTrack/LoadTracksWithMediaType/ LoadTracksWithMediaCharacteristic methods in: - AVAsset (AVCompositionTrack -> AVAssetTrack) - AVMutableMovie (AVMovieTrack -> AVMutableMovieTrack) - AVFragmentedMovie (AVMutableCompositionTrack -> AVFragmentedMovieTrack) - AVComposition (AVMutableCompositionTrack -> AVCompositionTrack) Fixes #25606. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…d signatures. Tests cover the new correctly-typed callback overloads for: - AVAsset.LoadTrack2, LoadTrackWithMediaCharacteristics, LoadTracksWithMediaType - AVMovie.LoadTrack, LoadTracksWithMediaType, LoadTracksWithMediaCharacteristic - AVMutableMovie.LoadTrack2, LoadTracksWithMediaType, LoadTracksWithMediaCharacteristic - AVComposition.LoadTrack, LoadTracksWithMediaType, LoadTracksWithMediaCharacteristic Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #1ad0603] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #1ad0603] Build passed (Build packages) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🔥 [PR Build #1ad0603] Build failed (Build macOS tests) 🔥Build failed for the job 'Build macOS tests' (with job status 'Failed') Pipeline on Agent |
🔥 [CI Build #1ad0603] Test results 🔥Test results❌ Tests failed on VSTS: test results 5 tests crashed, 92 tests failed, 76 tests passed. Failures❌ cecil tests1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (iOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (MacCatalyst)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (macOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (tvOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (iOS)20 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (MacCatalyst)23 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (macOS)23 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)20 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ windows tests1 tests failed, 2 tests passed.Failed tests
|
🔥 [CI Build #1ad0603] Test results 🔥Test results❌ Tests failed on VSTS: test results 5 tests crashed, 104 tests failed, 64 tests passed. Failures❌ cecil tests1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (iOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (MacCatalyst)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (macOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (tvOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ interdependent-binding-projects tests2 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download ❌ linker tests (iOS)11 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (iOS)20 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (MacCatalyst)23 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (macOS)23 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)20 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ Tests on macOS Monterey (12) tests🔥 Failed catastrophically on VSTS: test results - mac_monterey (no summary found). Html Report (VSDrops) Download ❌ Tests on macOS Ventura (13) tests🔥 Failed catastrophically on VSTS: test results - mac_ventura (no summary found). Html Report (VSDrops) Download ❌ Tests on macOS Sonoma (14) tests🔥 Failed catastrophically on VSTS: test results - mac_sonoma (no summary found). Html Report (VSDrops) Download ❌ Tests on macOS Sequoia (15) tests🔥 Failed catastrophically on VSTS: test results - mac_sequoia (no summary found). Html Report (VSDrops) Download ❌ Tests on macOS Tahoe (26) tests🔥 Failed catastrophically on VSTS: test results - mac_tahoe (no summary found). Html Report (VSDrops) Download Successes✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download macOS testsLinux Build VerificationPipeline on Agent |
The completion handler callbacks for
LoadTrack*/LoadTracks*methods on several AVFoundation classes had incorrect parameter types (e.g.AVMutableCompositionTrackinstead ofAVMovieTrack).This PR:
XAMCORE_5_0)2suffix where naming conflicts arise due to delegate type inheritance relationships (AVAsset, AVMutableMovie)Affected classes:
AVAsset:LoadTrack2,LoadTrackWithMediaCharacteristics,LoadTracksWithMediaTypeAVMovie(category):LoadTrack,LoadTracksWithMediaType,LoadTracksWithMediaCharacteristicAVMutableMovie:LoadTrack2,LoadTracksWithMediaType,LoadTracksWithMediaCharacteristicAVFragmentedMovie(category):LoadTrack,LoadTracksWithMediaType,LoadTracksWithMediaCharacteristicAVComposition(category):LoadTrack,LoadTracksWithMediaType,LoadTracksWithMediaCharacteristicFixes #25606
🤖 Pull request created by Copilot