[tools] Honor the 'ProductException.Warning' field if nothing has been configured for an exception.

[rolfbjarne]

No description provided.

[Copilot]

Pull request overview

This PR updates the tool error/warning classification flow so ProductException.Warning is honored when no per-code warning configuration exists, while ensuring that true errors remain errors regardless of configuration defaults.

Changes:

• Added ErrorHelper.TryGetWarningLevel to distinguish “no configuration found” from “configured to Warning”.
• Updated ProductException.IsError/GetWarningLevel to (a) always treat non-warning exceptions as errors and (b) only consult configured warning levels when present.
• Mirrored the ErrorHelper warning-level lookup changes in the test helper implementation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
tools/common/ErrorHelper.tools.cs	Adds TryGetWarningLevel and refactors GetWarningLevel to use it.
tools/common/error.cs	Fixes ProductException warning/error classification to consistently reflect the exception’s Warning field when unconfigured.
tests/common/ErrorHelper.tests.cs	Keeps the test helper ErrorHelper behavior consistent with the production implementation.

[vs-mobiletools-engineering-service2]

✅ [PR Build #7f4565e] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 7f4565e8536694a3ecf0e4268018350754875825 [PR build]

[vs-mobiletools-engineering-service2]

✅ [PR Build #7f4565e] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 7f4565e8536694a3ecf0e4268018350754875825 [PR build]

[vs-mobiletools-engineering-service2]

✅ API diff for current PR / commit

NET (empty diffs)

• iOS: vsdrops gist ( No breaking changes )
• tvOS: vsdrops gist ( No breaking changes )
• MacCatalyst: vsdrops gist ( No breaking changes )
• macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

• iOS: vsdrops gist ( No breaking changes )
• tvOS: vsdrops gist ( No breaking changes )
• MacCatalyst: vsdrops gist ( No breaking changes )
• macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 7f4565e8536694a3ecf0e4268018350754875825 [PR build]

[vs-mobiletools-engineering-service2]

✅ [PR Build #7f4565e] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 7f4565e8536694a3ecf0e4268018350754875825 [PR build]

[vs-mobiletools-engineering-service2]

🚀 [CI Build #7f4565e] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 199 tests passed 🎉

Tests counts

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 18 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 17 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 18 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 7f4565e8536694a3ecf0e4268018350754875825 [PR build]