Conversation
Buttons that specified a border color but not a width would render the border in Windows but not in other platforms.
rachelkang
approved these changes
Mar 2, 2023
Eilon
added
the
area-templates
PureWeen
reviewed
Mar 2, 2023
| <Setter Property="BackgroundColor" Value="{AppThemeBinding Light={StaticResource Primary}, Dark={StaticResource White}}" /> | ||
| <Setter Property="FontFamily" Value="OpenSansRegular"/> | ||
| <Setter Property="FontSize" Value="14"/> | ||
| <Setter Property="BorderWidth" Value="0"/> |
Member
There was a problem hiding this comment.
@davidortinau any complaints here? A possible different approach here would be to use OnPlatform to specify whatever the default is on WinUI
This will still keep them different but it's at least discoverable.
Either approach probably accomplishes the same thing though, and this change is probably fine.
samhouts
added
the
fixed-in-8.0.0-preview.3.8149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buttons that specified a border color but not a width would render the border in Windows but not in other platforms.
Description of Change
As discussed with @PureWeen, the approach towards solving this issue was to set the
BorderWidthof the button style equal to 0 in the project template. This ensures consistent behavior across platforms without modifying the native behavior in either.Issues Fixed
Fixes #13612