[iOS] Auto Resize chrome icons on iOS to make it more consistent with other platforms - hamburger icon #29095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubaflo
added
platform/ios
area-controls-shell
kubaflo
force-pushed
the
AutoresizeFlyoutIcon
branch
from
a99641c to
9ad10f7
Compare
jsuarezruiz
suggested changes
Apr 21, 2025
Contributor
jsuarezruiz
suggested changes
Apr 21, 2025
| public void ShellFlyoutIconShouldAutoscale() | ||
| { | ||
| App.WaitForElement("HelloWorldLabel"); | ||
| VerifyScreenshot(); |
Contributor
There was a problem hiding this comment.
Pending snapshots already available in the latest build.
| public void ShellFlyoutIconShouldAutoscale() | ||
| { | ||
| App.WaitForElement("HelloWorldLabel"); | ||
| VerifyScreenshot(); |
Contributor
There was a problem hiding this comment.
Pending snapshots already available in the latest build.
kubaflo
force-pushed
the
AutoresizeFlyoutIcon
branch
from
9ad10f7 to
1f95ee1
Compare
kubaflo
force-pushed
the
AutoresizeFlyoutIcon
branch
from
1f95ee1 to
762a9c4
Compare
kubaflo
force-pushed
the
AutoresizeFlyoutIcon
branch
from
762a9c4 to
6611354
Compare
PureWeen
added
the
p/0
PureWeen
requested changes
Jun 20, 2025
src/Controls/src/Core/Compatibility/Handlers/NavigationPage/iOS/NavigationRenderer.cs
Outdated
Show resolved
Hide resolved
kubaflo
force-pushed
the
AutoresizeFlyoutIcon
branch
from
7f44688 to
e01f17a
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
previously approved these changes
Jul 3, 2025
Member
|
Member
|
I had missed @Tamilarasan-Paranthaman 's comments Going to close this PR in favor of #26016 and get @Tamilarasan-Paranthaman to integrate these changes in. |
github-project-automation
bot
moved this from Ready To Review
to Done
in MAUI SDK Ongoing
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #29092