[Android] [a11y] Support fot the button role to spans with GestureRecognizer#29307
Open
kubaflo wants to merge 2 commits intodotnet:mainfrom
Open
[Android] [a11y] Support fot the button role to spans with GestureRecognizer#29307kubaflo wants to merge 2 commits intodotnet:mainfrom
kubaflo wants to merge 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances accessibility support by adding logic to handle the button role for spans with a GestureRecognizer, ensuring that tap gestures with a single tap are correctly recognized.
- Added iteration over CompositeGestureRecognizers to handle accessibility for tap gestures.
- Returns a primary button check when an eligible GestureRecognizer is found.
| } | ||
| } | ||
|
|
||
| foreach (var gesture in virtualView.GestureController.CompositeGestureRecognizers) |
There was a problem hiding this comment.
The logic for determining the primary button is now duplicated in two separate code blocks. Consider refactoring the common check into a helper method to improve maintainability.
kubaflo
added
platform/android
t/a11y
|
@mattleibow @rmarinho @kubaflo How to proceed here? |
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 29307Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 29307" |
StephaneDelcroix
requested changes
Mar 18, 2026
| { | ||
| internal static bool HasAccessibleTapGesture(this View virtualView) => | ||
| HasAccessibleTapGesture(virtualView, out _); | ||
| internal static bool ControlsAccessibilityDelegateNeeded(this View virtualView) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issues Fixed
Fixes #25763