Make implicit package refs privateassets=all#8064
Merged
Conversation
Related to #8032 When doing `dotnet new mauilib` and then `dotnet pack` the implicit package references here are being added as dependencies to the generated nupkg's, which isn't quite correct since they will take a versioned dependency on them which can cause issues for apps consuming these packages between versions of MAUI. This should stop MAUI libraries from including these packages as dependencies.
Redth
added
the
area-single-project
jonathanpeppers
approved these changes
Jun 15, 2022
mattleibow
approved these changes
Jun 15, 2022
DeanFaizal
approved these changes
Jun 15, 2022
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 2 pipeline(s). |
Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #8032
When doing
dotnet new mauiliband thendotnet packthe implicit package references here are being added as dependencies to the generated nupkg's, which isn't quite correct since they will take a versioned dependency on them which can cause issues for apps consuming these packages between versions of MAUI.This should stop MAUI libraries from including these packages as dependencies.