[Windows] Add a root view for a window to manage pages and overlays#8428
Merged
PureWeen merged 3 commits intorelease/6.0.4xx-sr2from Jun 30, 2022
Merged
[Windows] Add a root view for a window to manage pages and overlays#8428PureWeen merged 3 commits intorelease/6.0.4xx-sr2from
PureWeen merged 3 commits intorelease/6.0.4xx-sr2from
Conversation
mattleibow
added
platform/windows
area-navigation
Contributor
|
@mattleibow Can you try hovering over the Live Visual Tree in Visual Studio and verify that the adorners are appearing again over MAUI elements? I don't think there is an API change here so the current version (I think) "should just work (tm)". |
Contributor
|
/azp run |
hartez
approved these changes
Jun 30, 2022
PureWeen
requested changes
Jun 30, 2022
- make sure pages always get inserted below overlay
mattleibow
commented
Jun 30, 2022
Member
Author
mattleibow
left a comment
mattleibow
left a comment
There was a problem hiding this comment.
Works for me on Android and Windows. There is a bit of an offset for Android, but @drasticactions has a PR/Fix/Merged in the UI Tools repos.
PureWeen
approved these changes
Jun 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Over the last set of commits, we tried to improve performance and reduce the view nesting and layout churn. Inadvertently we removed a root view that appeared to not be used. #7172 This is a result of code not actually using the type and was just casting to Panel or some other base type.
This PR adds the view back, but also adds it back in a more useful way. Most notable the page managers use the type directly to add pages and the overly managers use it to add overlays. Instead of everyone grabbing the view and putting their bits in, we should use the new api so that overlays correctly are added to the top and pages underneath.
Issues Fixed
Fixes #8096