Merged
Conversation
Member
|
Why is this ? can we add some more documentation here? |
Member
Author
|
I see CI is failing because it needs a newer Java:
|
Member
|
what are we missing here @mattleibow ? |
Member
Author
|
Figuring out where the android sdk is I think... The build was failing last with not being found... Or maybe it was Java 11. I wonder if we can maybe set an envvar of ANDROID_SDK_ROOT to the Android sdk path |
hartez
approved these changes
Mar 7, 2023
samhouts
added
the
area-infrastructure
samhouts
added
the
fixed-in-8.0.0-preview.3.8149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Make sure to build the maui.aar binary on CI.
The current behaviour is that the aar needs to be built locally and then checked in. This means there is no way to know what is in the aar and potential for all sorts of issues. Building this part on CI make sure the code in the repo is what is shipped.