Copy relevant try-convert contents to UA repo#1248
Merged
brandonh-msft merged 6 commits intomainfrom Aug 4, 2022
Merged
Conversation
brandonh-msft
added
enhancement
sunandabalu
previously approved these changes
Aug 2, 2022
Contributor
Author
|
Only diffs are expected ones |
brandonh-msft
force-pushed
the
1242-copy-try-convert-into-ua-repo-instead-of-subrepoing-it
branch
from
6618d0f to
1929d47
Compare
UA has different SA/CA rules than t-c did. It's pretty odd these weren't caught prior CI builds w/ this code in place, but nevertheless the fixes are all done and code builds locally w/o issue and all UTs pass. No logic was harmed in the making of this commit. 🤞🏻
brandonh-msft
force-pushed
the
1242-copy-try-convert-into-ua-repo-instead-of-subrepoing-it
branch
from
1929d47 to
01aaab2
Compare
brandonh-msft
deleted the
1242-copy-try-convert-into-ua-repo-instead-of-subrepoing-it
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our PRs into the try-convert project are gated on contributors,
while that project is openly stated as unmaintained.
Since we were previously pinning to an exact commit in t-c anyway,
we have decided to move forward with copying the portions of t-c
which UA utilizes directly into the try-convert extension area of
the project.
This will allow for faster iteration on fixes/extensions that require
updates to try-convert's functionality and decouple us from a
deprecated project.
Fixes #1242