Analyzers prototyping - Representative analyzers set

[JanKrivanek]

Context

#9627

• Let's go through ideas and build interesting initial set
• Mark the analyzers in the set based on viability based on EventArgs ('Doable today', 'Doable with slight adjust of EventArgs with minimum implementation and perf cost', 'More complicated')
• Let's choose few from the first 2 categories above, Expose OM for them and author them

The main part should be the last point

FYI @ladipro (this is based on your suggestion)

References

• [Internal link] analyzer ideas

Work to be done for the first set of analyzers:

• [Built-in analyzer] Multiple projects share the same obj/bin #9879
• [Built-in analyzer] TargetFramework and TargetFrameworks are both set #9880
• [Built-in analyzer] The same file is written by multiple tasks during the build #9881
• [Built-in analyzer] EmbeddedResource item is missing the Culture metadata #9882
• [Built-in analyzer] Undefined property is used #9883
• [Built-in analyzer] Item is updated inside a target #9884
• [Built-in analyzer] Build depends on an environment variable #9885
• [Built-in analyzer] Reference item points to the output of a project #9888
• [Built-in analyzer] MSBuild task with BuildInParallel is batched #9889
• [Built-in analyzer] Property that starts with an underscore is set #9891
• [Built-in analyzer] String comparison is not properly quoted #9892

Condidates for followup set:

• Analyzer for redundant NuGet packages sdk#44533
• Analyzer for resolving from Program Files #10305

[JanKrivanek]

Candidates:

• Warning Waves Items
• Internal Ideas Dump

Top 3 by @rainersigwald:

• project-instance races with the same bin/obj
• double writes
• forbidding References to outputs of this repo (in favor of ProjectReferences)

Other top candidates:

• Introduce analyzer or some other mechanism to flag builds that invoke the compiler (i.e. CoreCompile target) with same inputs and outputs to avoid race conditions #9781
• Mixing TargetFramework and TargetFrameworks in a single project - very easy to check, and there is probably no logitimate usage for the case.

[ladipro]

Here's the list of analyzers we would like to ship, each with its own issue:

• [Built-in analyzer] Multiple projects share the same obj/bin #9879
• [Built-in analyzer] TargetFramework and TargetFrameworks are both set #9880
• [Built-in analyzer] The same file is written by multiple tasks during the build #9881
• [Built-in analyzer] EmbeddedResource item is missing the Culture metadata #9882
• [Built-in analyzer] Undefined property is used #9883
• [Built-in analyzer] Item is updated inside a target #9884
• [Built-in analyzer] Build depends on an environment variable #9885
• [Built-in analyzer] Reference item points to the output of a project #9888
• [Built-in analyzer] MSBuild task with BuildInParallel is batched #9889
• [Built-in analyzer] Property that starts with an underscore is set #9891
• [Built-in analyzer] String comparison is not properly quoted #9892

I'll close this one and we'll continue in individual issues. Each proposed analyzer is a bit different and the devil is in the details, as they say.

[stan-sz]

This seems relevant to #1777