Erarndt/drain packet queue reorder fix #12190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses ARM64-specific failures by refactoring the node communication packet queue implementation to prevent instruction reordering issues and improve resource management. The changes replace thread-based packet draining with an async task-based approach and add explicit memory barriers.
Key changes:
- Refactored packet queue draining from dedicated thread to async Task-based implementation
- Added memory barriers to prevent instruction reordering on ARM64 architecture
- Improved resource management with proper using statements and disposal patterns
src/Build/BackEnd/Components/Communications/NodeProviderOutOfProcBase.cs
Show resolved
Hide resolved
src/Build/BackEnd/Components/Communications/NodeProviderOutOfProcBase.cs
Show resolved
Hide resolved
src/Build/BackEnd/Components/Communications/NodeProviderOutOfProcBase.cs
Show resolved
Hide resolved
rainersigwald
approved these changes
Jul 22, 2025
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
I'm happy to go in with this but let's let @YuliiaKovalova coordinate an isolated insertion so we can hopefully see more clearly if it's introducing problems.
YuliiaKovalova
approved these changes
Jul 22, 2025
Member
YuliiaKovalova
left a comment
YuliiaKovalova
left a comment
There was a problem hiding this comment.
now it's the best time to have it isolated :)
rainersigwald
added a commit
that referenced
this pull request
Jul 24, 2025
This reverts commit 533b6c5.
rainersigwald
added a commit
that referenced
this pull request
Jul 24, 2025
Reverts #12190 -- it reintroduced ARM64 failures, see https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2533913/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
This PR addresses issues that were identified in this PR #11918 that were causing failures on ARM64.
Changes Made
Testing
Notes