Make runtimeAssembliesCLR35_20 lazy#12928
Merged
YuliiaKovalova merged 3 commits intomainfrom Dec 12, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves startup performance by making the runtimeAssembliesCLR35_20 field lazy-initialized, ensuring that CLR 2.0 and 3.5 assemblies are only enumerated when actually needed. This is an enhancement to PR #12823, reducing unnecessary initialization costs for NETFRAMEWORK builds.
Key changes:
- Converts
runtimeAssembliesCLR35_20from an eagerly-initialized static field to aLazy<string[]>for deferred initialization - Adds deduplication logic to prioritize CLR 3.5 assemblies over CLR 2.0 assemblies when both contain the same assembly names
- Extracts the
AddAssembliesToDictionaryhelper method from a local function to a private static method for reuse
MichalPavlik
approved these changes
Dec 12, 2025
This was referenced Dec 13, 2025
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Dec 15, 2025
This reverts commit fd4375f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improvement for #12823