Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables ProjectReference to work with virtual (in-memory) projects when _BuildNonexistentProjectsByDefault is enabled, supporting SDK scenarios like file-based apps that synthesize projects into the ProjectRootElementCache.
Changes:
- Update
_SplitProjectReferencesByFileExistenceto treat allProjectReferenceitems as “existent” when_BuildNonexistentProjectsByDefault=true. - Add unit tests validating both the split behavior and end-to-end
ResolveProjectReferencesbehavior with in-memory projects. - Extend the spec to document
ProjectReferencebehavior and virtual project limitations (notably out-of-proc node isolation).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Tasks/Microsoft.Common.CurrentVersion.targets | Bypasses Exists() classification for project references when building nonexistent projects by default, enabling virtual references. |
| src/Build.UnitTests/BackEnd/MSBuild_Tests.cs | Adds coverage for virtual ProjectReference behavior (split + end-to-end build). |
| documentation/specs/build-nonexistent-projects-by-default.md | Documents new ProjectReference behavior and clarifies constraints for virtual projects. |
You can also share your feedback on Copilot code review. Take the survey.
Member
Author
|
@dotnet/msbuild for a review of this simple change that would allow us to implement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of dotnet/sdk#53478.