Fix stray brace in HandleBuildCancel trace string causing MSB1025#13535
Merged
Conversation
Contributor
|
Hello @copilot, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo. |
Agent-Logs-Url: https://github.com/dotnet/msbuild/sessions/2704aba7-0c9c-4e8d-bead-b176ac45df32 Co-authored-by: rainersigwald <3347530+rainersigwald@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix MSB1025 internal failure on build cancel
Fix stray brace in HandleBuildCancel trace string causing MSB1025
Apr 13, 2026
rainersigwald
approved these changes
Apr 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a cancellation-path crash in the out-of-proc MSBuild server by correcting an invalid trace format string that could throw a FormatException (surfacing as MSB1025) when tracing is enabled.
Changes:
- Remove a stray
}from theHandleBuildCanceltrace message inOutOfProcServerNode, preventingstring.Formatfailures during cancel.
JanProvaznik
approved these changes
Apr 14, 2026
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
}in trace format string atOutOfProcServerNode.cs:343}in theHandleBuildCanceltrace messageMSB1025/FormatExceptionwithMSBuildDebugEngine=1 DOTNET_CLI_USE_MSBUILD_SERVER=1+ cancelMSB1025— trace file shows message written successfully