Skip to content

[automated] Merge branch 'vs18.5' => 'vs18.6'#13557

Open
github-actions[bot] wants to merge 6 commits intovs18.6from
merge/vs18.5-to-vs18.6
Open

[automated] Merge branch 'vs18.5' => 'vs18.6'#13557
github-actions[bot] wants to merge 6 commits intovs18.6from
merge/vs18.5-to-vs18.6

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

I detected changes in the vs18.5 branch which have not been merged yet to vs18.6. I'm a robot and am configured to help you automatically keep vs18.6 up to date, so I've opened this PR.

This PR merges commits made on vs18.5 by the following committers:

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout vs18.5
git pull --ff-only
git checkout vs18.6
git pull --ff-only
git merge --no-ff vs18.5

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet/msbuild HEAD:merge/vs18.5-to-vs18.6
or if you are using SSH
git push git@github.com:dotnet/msbuild HEAD:merge/vs18.5-to-vs18.6

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/vs18.5-to-vs18.6'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.

git fetch
git checkout -b merge/vs18.5-to-vs18.6 origin/vs18.6
git pull https://github.com/dotnet/msbuild merge/vs18.5-to-vs18.6
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet/msbuild HEAD:merge/vs18.5-to-vs18.6
or if you are using SSH
git fetch
git checkout -b merge/vs18.5-to-vs18.6 origin/vs18.6
git pull git@github.com:dotnet/msbuild merge/vs18.5-to-vs18.6
(make changes)
git commit -m "Updated PR with my changes"
git push git@github.com:dotnet/msbuild HEAD:merge/vs18.5-to-vs18.6

Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.

MichalPavlik and others added 6 commits February 26, 2026 15:45
Fixes #13374

### Context
tasks enlightened for multithreading and their derivations crash
1. when they are explicitly instantiated 
2. run in taskhost 

### Changes Made
- introduce `FallbackMultiProcessEnvironmentDriver` (polyfilled
implementation of the `MultiProcessEnvironmentDriver`)
- make it a default value of the TaskEnvironment property for all
enlightened tasks

### Testing
- unit tests
- [x] TBD manual test of the failing scenarios

### Notes
…close (#13448)

Work item (Internal use): devdiv2668876

### Summary

Internal bookkeeping about phase durations hit a production assert,
causing user hangs in VS. We can make the bookkeeping never throw.

ScheduleTimeRecord.AccumulatedTime throws InternalErrorException with
'Can't get the accumulated time while the timer is still running' during
Scheduler.WriteDetailedSummary(). This exception kills the BuildManager
work queue, preventing any further build results from being processed.
EndBuild() hangs indefinitely, causing VS to freeze for hours.

The fix returns the best-effort elapsed time (accumulated + current
elapsed) when the timer is still running, instead of throwing.
This is diagnostic summary data — throwing has no correctness benefit
but causes a catastrophic hang.

### Customer Impact
Customers are reporting VS hang during project unload.

### Regression?
Yes

### Testing
New unit test added.

### Risk
Minimal. Removes an exception path entirely. Inaccurate summary times
could result but should be strictly better than a hang.

---------

Co-authored-by: YuliiaKovalova <ykovalova@microsoft.com>
Co-authored-by: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com>
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Co-authored-by: MichalPavlik <michalpavlik@outlook.com>
…er shutdown (#13549)

Backport of #13450 to vs18.5

/cc @rainersigwald @YuliiaKovalova

---------

Co-authored-by: Yuliia Kovalova <ykovalova@microsoft.com>
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
@github-actions github-actions bot requested a review from a team as a code owner April 17, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants