Removed WMI due to performance

[MichalPavlik]

Fixes #13550

Context

WMI is causing issues, so we need to remove it now and find a better solution.

Changes Made

WMI code was removed and Windows is treated as unsupported OS.

Testing

Manual testing with running MSBuild worker nodes.

Notes

[Copilot]

Pull request overview

This PR removes the Windows WMI-based implementation used to retrieve a process command line (to address significant performance regressions during node reuse scanning), and updates unit tests to reflect that command-line retrieval is not supported on Windows.

Changes:

• Removed the Windows WMI/COM-based command-line retrieval path from ProcessExtensions.TryGetCommandLine.
• Treated Windows as unsupported for command-line retrieval (returns null command line) and updated unit tests accordingly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/Framework/Utilities/ProcessExtensions.cs	Removes WMI-based Windows command-line retrieval to avoid the perf hit.
src/Utilities.UnitTests/ProcessExtensions_Tests.cs	Updates expectations on Windows to assert commandLine is null.

[Copilot]

TryGetCommandLine now treats Windows/other platforms as unsupported (returns true with commandLine == null). However, the method's XML doc says it returns false when the platform doesn't support command-line retrieval, and the unsupported-OS branch comment says "return false" even though it returns true. Please align the docs/comments with the actual contract (or adjust the return value/contract consistently across callers).

[github-actions]

Correctness & Edge Cases — one issue found

Comment/code mismatch (line 78): The comment says "return false" but the code returns true. This is not a runtime bug — the true + null return is correct for the callers — but the comment directly contradicts the code it describes.

Everything else checks out:

• Callers handle (true, null) correctly. Both call sites in NodeProviderOutOfProcBase.cs explicitly guard if (commandLine is null) and include the process, which is the right fallback when command-line retrieval is unsupported.
• ExtractFromCommandLine is null-safe. It checks string.IsNullOrWhiteSpace up front, so even if a BSD/Linux helper returned null, callers would not crash (though they'd get NodeMode? == null and exclude the process — the null guard in callers fires first anyway).
• XML doc <returns> is slightly misleading (says "true if successfully retrieved" but true also means "unsupported platform"), however this is a pre-existing issue — the .NET Framework path already returned (true, null) before this PR.

Generated by Expert Code Review (on open) for issue #13610 · ● 11.7M

[github-actions]

🔍 Skill Validator Results

✅ All checks passed

Scope	Checked
Skills	7
Agents	1
Total	8
Severity	Count
---	---:
❌ Errors	0
⚠️ Warnings	0
ℹ️ Advisories	0

Summary

Level	Finding
ℹ️	Found 7 skill(s)
ℹ️	[assessing-breaking-changes] 📊 assessing-breaking-changes: 992 BPE tokens [chars/4: 1,154] (detailed ✓), 8 sections, 2 code blocks
ℹ️	[maintaining-binary-log-compatibility] 📊 maintaining-binary-log-compatibility: 1,271 BPE tokens [chars/4: 1,509] (detailed ✓), 12 sections, 2 code blocks
ℹ️	[authoring-errors-and-warnings] 📊 authoring-errors-and-warnings: 1,287 BPE tokens [chars/4: 1,393] (detailed ✓), 13 sections, 4 code blocks
ℹ️	[changewaves] 📊 changewaves: 901 BPE tokens [chars/4: 1,007] (detailed ✓), 9 sections, 1 code blocks
ℹ️	[running-unit-tests] 📊 running-unit-tests: 2,376 BPE tokens [chars/4: 2,310] (detailed ✓), 10 sections, 6 code blocks
ℹ️	[optimizing-msbuild-performance] 📊 optimizing-msbuild-performance: 1,182 BPE tokens [chars/4: 1,342] (detailed ✓), 10 sections, 1 code blocks
ℹ️	[integrating-sdk-and-msbuild] 📊 integrating-sdk-and-msbuild: 1,250 BPE tokens [chars/4: 1,440] (detailed ✓), 14 sections, 2 code blocks
ℹ️	✅ All checks passed (7 skill(s))
ℹ️	Found 1 agent(s)

Full validator output

```text Found 7 skill(s) [assessing-breaking-changes] 📊 assessing-breaking-changes: 992 BPE tokens [chars/4: 1,154] (detailed ✓), 8 sections, 2 code blocks [maintaining-binary-log-compatibility] 📊 maintaining-binary-log-compatibility: 1,271 BPE tokens [chars/4: 1,509] (detailed ✓), 12 sections, 2 code blocks [authoring-errors-and-warnings] 📊 authoring-errors-and-warnings: 1,287 BPE tokens [chars/4: 1,393] (detailed ✓), 13 sections, 4 code blocks [changewaves] 📊 changewaves: 901 BPE tokens [chars/4: 1,007] (detailed ✓), 9 sections, 1 code blocks [running-unit-tests] 📊 running-unit-tests: 2,376 BPE tokens [chars/4: 2,310] (detailed ✓), 10 sections, 6 code blocks [optimizing-msbuild-performance] 📊 optimizing-msbuild-performance: 1,182 BPE tokens [chars/4: 1,342] (detailed ✓), 10 sections, 1 code blocks [integrating-sdk-and-msbuild] 📊 integrating-sdk-and-msbuild: 1,250 BPE tokens [chars/4: 1,440] (detailed ✓), 14 sections, 2 code blocks ✅ All checks passed (7 skill(s)) Found 1 agent(s) Validated 1 agent(s)

✅ All checks passed (1 agent(s))

</details>