[main] Source code updates from dotnet/dotnet#13735
Conversation
No dependency updates to commit [[ commit created by automation ]]
|
@JanProvaznik The change removed the version specification and it caused package version conflicts. See https://dev.azure.com/dnceng-public/public/_build/results?buildId=1416751&view=logs&j=20125c81-7edb-551b-693a-61efae016b74&t=7ce25265-aabe-59d3-d73c-06619cfcc3c4&l=80. My change restoring back the version turned out we still need it.
No idea where the change is from, especially the add to |
|
@GangWang01 this kind of PR is generated based on merged changes in https://github.com/dotnet/dotnet/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Aopen there should be a PR for it explaining the rationale. I am against reverting if we don't understand why it came to us. |
c5a4ae1 to
176af60
Compare
|
We should revert the change causing the error |
|
That's not the way to go. Reverting this here will just introduce the error again on the VMR side. We need input from @agocke on how to best handle this in both worlds: VMR (arcade main) & msbuild (Arcade 10). |
|
dotnet/dotnet#6604 shows the failure now again due to the revert |
@ViktorHofer |
Note
This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Associated changes in source repos
Diff the source with this PR branch