Revert "Fix ToolTask hang when grandchild processes inherit pipe handles (#13351)"#13945
Open
JanProvaznik wants to merge 3 commits into
Open
Revert "Fix ToolTask hang when grandchild processes inherit pipe handles (#13351)"#13945JanProvaznik wants to merge 3 commits into
JanProvaznik wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the vs18.7 backport of the ToolTask stdout/stderr pipe EOF handling change (#13351), restoring the prior ToolTask process-exit waiting behavior and removing the associated regression coverage and change-wave documentation entry.
Changes:
- Remove the Wave18_6-gated ToolTask EOF-signaling + bounded EOF wait logic, restoring parameterless
Process.WaitForExit(). - Remove the unit tests added to cover the grandchild-pipe-handle hang scenario and output-capture behavior.
- Update ChangeWaves documentation to remove the 18.6 entry for the reverted feature.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Utilities/ToolTask.cs | Reverts the process exit / output EOF handling changes and removes related fields/disposal. |
| src/Utilities.UnitTests/ToolTask_Tests.cs | Removes regression tests that validated the reverted ToolTask behavior. |
| documentation/wiki/ChangeWaves.md | Removes the Wave 18.6 documentation bullet for the reverted ToolTask fix. |
JanProvaznik
force-pushed
the
revert-13351-vs18.7
branch
from
83488bc to
c94810e
Compare
AlesProkop
approved these changes
Jun 4, 2026
…les (dotnet#13351)" This reverts commit 6c499a7. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JanProvaznik
force-pushed
the
revert-13351-vs18.7
branch
from
c94810e to
a36f23a
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
merge on monday to get to the next QB window |
rainersigwald
approved these changes
Jun 4, 2026
| value: ${{ parameters.TargetBranch }} | ||
| ${{ else }}: | ||
| value: 'main' | ||
| value: 'rel/stable' |
Member
There was a problem hiding this comment.
I don't love having to change this but it's ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #13351 on the
vs18.7branch.This reverts commit 6c499a7 (
Fix ToolTask hang when grandchild processes inherit pipe handles).