Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automated] Merge branch 'vs17.4' => 'vs17.5' #8448

Merged
merged 24 commits into from
Feb 16, 2023

Conversation

dotnet-maestro-bot
Copy link
Contributor

I detected changes in the vs17.4 branch which have not been merged yet to vs17.5. I'm a robot and am configured to help you automatically keep vs17.5 up to date, so I've opened this PR.

This PR merges commits made on vs17.4 by the following committers:

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout vs17.4
git pull --ff-only
git checkout vs17.5
git pull --ff-only
git merge --no-ff vs17.4

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet-maestro-bot/msbuild HEAD:merge/vs17.4-to-vs17.5
or if you are using SSH
git push git@github.com:dotnet-maestro-bot/msbuild HEAD:merge/vs17.4-to-vs17.5

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/vs17.4-to-vs17.5'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.

git checkout -b merge/vs17.4-to-vs17.5 vs17.5
git pull https://github.com/dotnet-maestro-bot/msbuild merge/vs17.4-to-vs17.5
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet-maestro-bot/msbuild HEAD:merge/vs17.4-to-vs17.5
or if you are using SSH
git checkout -b merge/vs17.4-to-vs17.5 vs17.5
git pull git@github.com:dotnet-maestro-bot/msbuild merge/vs17.4-to-vs17.5
(make changes)
git commit -m "Updated PR with my changes"
git push git@github.com:dotnet-maestro-bot/msbuild HEAD:merge/vs17.4-to-vs17.5

Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.

dotnet-maestro bot and others added 23 commits March 3, 2022 14:44
* Update dependencies from https://github.com/dotnet/arcade build 20220105.3

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21505.11 -> To Version 5.0.0-beta.22055.3

* Update dependencies from https://github.com/dotnet/arcade build 20220204.7

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21505.11 -> To Version 5.0.0-beta.22104.7

* Update dependencies from https://github.com/dotnet/arcade build 20220222.5

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21505.11 -> To Version 5.0.0-beta.22122.5

* Update dependencies from https://github.com/dotnet/arcade build 20220223.4

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21505.11 -> To Version 5.0.0-beta.22123.4

* update mac version

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Forgind <Forgind@users.noreply.github.com>
…309.5

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.22123.4 -> To Version 5.0.0-beta.22159.5
…526.2

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.22123.4 -> To Version 5.0.0-beta.22276.2
* Avoid AssemblyName.KeyPair on .NET

It throws on .NET 6 and wasn't helpful before anyway:

(from https://docs.microsoft.com/en-us/dotnet/api/system.reflection.assemblyname.keypair?view=net-5.0#remarks):

> When the runtime loads an assembly, it does not set the KeyPair property. The getter for the property is only useful if the user set the property before using the AssemblyName object to create a dynamic assembly, and subsequently wants to retrieve the key pair.

Also disable some parts of the official build that are currently broken, but don't affect building the bits that go into the .NET SDK.

Co-authored-by: Forgind <Forgind@users.noreply.github.com>
…ision-16.11

Fixes dotnet/sdk#25698 for 16.11, merging forward (+ infrastructure updates).
* Update the runsettings configuration creation for opt-prof v2 pipeline.

* Add opt-prof v2 pipeline configuration yml.
The win2016 images aren't live any more.
…16.11-to-vs17.0-2

Backport opt-prof v2 vs17.0 

- [vs16.11] Update dependencies from dotnet/arcade (dotnet#7332)
- Update dependencies from https://github.com/dotnet/arcade build 20220309.5
- Update dependencies from https://github.com/dotnet/arcade build 20220526.2
- Bump CLI version to match global.json
- Bump NuGet version to match
- Avoid AssemblyName.KeyPair on .NET (dotnet#7660)
- Merge remote-tracking branch 'upstream/vs16.9' into backport-keypair-elision-16.11
- Merge pull request dotnet#7663 from rainersigwald/backport-keypair-elision-16.11
- Configure OptProf v2 pipeline 16.11 (dotnet#8189)
- Updating 'Microsoft.DotNet.Arcade.Sdk': '5.0.0-beta.22276.2' => '5.0.0-beta.22526.12'
- Move BAR publish to windows-latest
- Merge pull request dotnet#8210 from rainersigwald/exp/16.11-build

### Testing
CI, Opt-prof CI
…17.0-to-vs17.2

Backport opt-prof v2 vs17.2

Brings the following changes from the 17.0 branch into 17.2:
- [vs16.11] Update dependencies from dotnet/arcade (dotnet#7332)
- Update dependencies from https://github.com/dotnet/arcade build 20220309.5
- Update dependencies from https://github.com/dotnet/arcade build 20220526.2
- Bump CLI version to match global.json
- Bump NuGet version to match
- Avoid AssemblyName.KeyPair on .NET (dotnet#7660)
- Merge remote-tracking branch 'upstream/vs16.9' into backport-keypair-elision-16.11
- Merge pull request dotnet#7663 from rainersigwald/backport-keypair-elision-16.11
- Configure OptProf v2 pipeline 16.11 (dotnet#8189)
- Updating 'Microsoft.DotNet.Arcade.Sdk': '5.0.0-beta.22276.2' => '5.0.0-beta.22526.12'
- Move BAR publish to windows-latest
- Merge pull request dotnet#8210 from rainersigwald/exp/16.11-build
- Merge remote-tracking branch 'upstream/vs16.11' into exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2
- Merge pull request dotnet#8260 from dotnet/exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2

### Testing
CI
…17.2-to-vs17.4

Backport opt-prof v2 vs17.4

Brings the following changes from the 17.2 branch into 17.4:
- [vs16.11] Update dependencies from dotnet/arcade (dotnet#7332)
- Update dependencies from https://github.com/dotnet/arcade build 20220309.5
- Update dependencies from https://github.com/dotnet/arcade build 20220526.2
- Bump CLI version to match global.json
- Bump NuGet version to match
- Avoid AssemblyName.KeyPair on .NET (dotnet#7660)
- Merge remote-tracking branch 'upstream/vs16.9' into backport-keypair-elision-16.11
- Merge pull request dotnet#7663 from rainersigwald/backport-keypair-elision-16.11
- Configure OptProf v2 pipeline 16.11 (dotnet#8189)
- Updating 'Microsoft.DotNet.Arcade.Sdk': '5.0.0-beta.22276.2' => '5.0.0-beta.22526.12'
- Move BAR publish to windows-latest
- Merge pull request dotnet#8210 from rainersigwald/exp/16.11-build
- Merge remote-tracking branch 'upstream/vs16.11' into exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2
- Merge pull request dotnet#8260 from dotnet/exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2
- Merge remote-tracking branch 'upstream/vs17.0' into exp/AR-May/opt-prof-fix-vs17.0-to-vs17.2
- Merge pull request dotnet#8264 from AR-May/exp/AR-May/opt-prof-fix-vs17.0-to-vs17.2

### Testing
CI
(Copied from dotnet#8351)

Fixes AB#1678521

Context
dotnet#8049 broke the temp filtering logic by using the MSBuild-specific temp path instead of the true base temp path. This manifests as an overbuild of some C++ projects.

Changes Made
Reverted the change. Enabled relevant unit tests.

Testing
Existing unit tests and a C++ end-to-end repro.

Notes
The rest of FileTracker tests cannot be enabled without significant work (related to dotnet#649).
Fixes AB#1678521

Context
dotnet#8049 broke the temp filtering logic by using the MSBuild-specific temp path instead of the true base temp path. This manifests as an overbuild of some C++ projects.

Changes Made
Reverted the change. Enabled relevant unit tests.

Testing
Existing unit tests and a C++ end-to-end repro.

Notes
The rest of FileTracker tests cannot be enabled without significant work (related to dotnet#649).
@Forgind
Copy link
Member

Forgind commented Feb 15, 2023

🥳 (Thanks @rainersigwald!)

@AR-May, I take it your optprof changes hadn't gone into 17.5? If they should, can you resolve the conflict? Not sure what it should be.

@rainersigwald
Copy link
Member

@AR-May, I take it your optprof changes hadn't gone into 17.5? If they should, can you resolve the conflict? Not sure what it should be.

They went into 17.5/main but via unrelated commits (they were there first), so the content was identical. I took the 17.5 version of everything (with the allow-keep-machines-around edit you ported).

@rainersigwald rainersigwald merged commit 8ce3029 into dotnet:vs17.5 Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants