Fix a cleanup issue in TestCluster after a failure#2734
Merged
ReubenBond merged 2 commits intodotnet:masterfrom Feb 15, 2017
Merged
Fix a cleanup issue in TestCluster after a failure#2734ReubenBond merged 2 commits intodotnet:masterfrom
ReubenBond merged 2 commits intodotnet:masterfrom
Conversation
Cleanup logic threw another exception that ended up masquerading the real exception and potentially leaking an initialized silo
ReubenBond
approved these changes
Feb 15, 2017
xiazen
reviewed
Feb 15, 2017
| catch (Exception) | ||
| { | ||
| this.additionalSilos.AddRange(siloStartTasks.Where(t => t.Exception != null).Select(t => t.Result)); | ||
| this.additionalSilos.AddRange(siloStartTasks.Where(t => t.Exception == null).Select(t => t.Result)); |
Contributor
There was a problem hiding this comment.
synced offline, we will add a logic to clean up silos which failed to start to enhance this fix.
Member
There was a problem hiding this comment.
@xiazen in this pr or a later pr? I'll leave it to you two
sergeybykov
pushed a commit
to sergeybykov/orleans
that referenced
this pull request
Feb 22, 2017
* Fix a cleanup issue in TestCluster after a failure Cleanup logic threw another exception that ended up masquerading the real exception and potentially leaking an initialized silo * Cleanup AppDomain when silo fails to start in TestCluster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup logic threw another exception that ended up masquerading the real exception and potentially leaking an initialized silo