Skip to content

Remove duplicate references to AdoNet.targets#4264

Merged
ReubenBond merged 1 commit intodotnet:masterfrom
sergeybykov:ado-cleanup
Mar 22, 2018
Merged

Remove duplicate references to AdoNet.targets#4264
ReubenBond merged 1 commit intodotnet:masterfrom
sergeybykov:ado-cleanup

Conversation

@sergeybykov
Copy link
Copy Markdown
Contributor

This is a follow-up to #4243.

There are currently build warnings while building Orleans.Persistence.AdoNet/Orleans.Persistence.AdoNet.csproj and Orleans.Reminders.AdoNet/Orleans.Reminders.AdoNet.csproj complaining about duplicate references to Microsoft.Orleans.Persistence.AdoNet.targets. This change seems to make build happy, and the content files still get copied to the project folder.

@veikkoeeva Could you double-check please.

@ReubenBond ReubenBond self-assigned this Mar 21, 2018
@veikkoeeva
Copy link
Copy Markdown
Contributor

The .target files seem to be still there, looking at the diff, and one time only this time. Also @sergeybykov mentions files are copied. The right thing to do, hopefully all good now. 👍

@ReubenBond ReubenBond merged commit bbca08f into dotnet:master Mar 22, 2018
@sergeybykov
Copy link
Copy Markdown
Contributor Author

Thank you, @veikkoeeva!

@sergeybykov sergeybykov deleted the ado-cleanup branch March 22, 2018 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants